Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tensorman: init at 0.1.0 #73452

Closed
wants to merge 10 commits into from
Closed

tensorman: init at 0.1.0 #73452

wants to merge 10 commits into from

Conversation

@thefenriswolf
Copy link
Contributor

@thefenriswolf thefenriswolf commented Nov 15, 2019

Motivation for this change

Easy management of Tensorflow containers with Docker as the backend.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

#{ pkgconfig, stdenv, rustPlatform, rustc, cargo, docker, openssl, fetchzip }:

rustPlatform.buildRustPackage rec {
name = "tensorman-${version}";

This comment has been minimized.

@mmahut

mmahut Nov 15, 2019
Member

Please use pname.

name = "tensorman-${version}";
version = "0.1.0";

src = fetchzip{

This comment has been minimized.

@mmahut

mmahut Nov 15, 2019
Member

Please use fetchFromGitHub with specific revision.

This comment has been minimized.

@thefenriswolf

thefenriswolf Nov 15, 2019
Author Contributor

not possible as they do not track their releases on github yet

version = "0.1.0";

src = fetchzip{
url = "https://github.com/pop-os/tensorman/archive/master_eoan.zip";

This comment has been minimized.

@mmahut

mmahut Nov 15, 2019
Member

This is going to fail after the first commit to master.

homepage = https://github.com/pop-os/tensorman/;
license = stdenv.lib.licenses.gpl3;
platforms = [ "x86_64-linux" ];
maintainers = [ ];

This comment has been minimized.

@mmahut

mmahut Nov 15, 2019
Member

Do you mind to maintain this package? We would like to avoid adding new packages without maintainers.

description = "Utility for easy management of Tensorflow containers";
homepage = https://github.com/pop-os/tensorman/;
license = stdenv.lib.licenses.gpl3;
platforms = [ "x86_64-linux" ];

This comment has been minimized.

@mmahut

mmahut Nov 15, 2019
Member

Could we try to build this on darwin maybe?

This comment has been minimized.

@thefenriswolf

thefenriswolf Nov 15, 2019
Author Contributor

it depends on docker and the developers state that it is written for Linux also I have no way of testing this on darwin

@thefenriswolf thefenriswolf requested a review from mmahut Nov 15, 2019
@thefenriswolf thefenriswolf requested a review from Lassulus Nov 20, 2019
@prusnak prusnak mentioned this pull request Nov 20, 2019
0 of 10 tasks complete
@Lassulus
Copy link
Contributor

@Lassulus Lassulus commented Nov 20, 2019

would be very nice If you could rebase your commit history and force push this branch, so we have 2 commits in the end, one for the maintainers addition and one for the package

Co-Authored-By: Lassulus <github@lassul.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.