Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos-container: allow custom nixpkgs path. #73458

Open
wants to merge 1 commit into
base: master
from

Conversation

@greydot
Copy link
Contributor

@greydot greydot commented Nov 15, 2019

This commit adds --nixpkgs-path option to create and update operations, allowing
the use of custom nixpkgs repos.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

or die "$0: failed to build initial container configuration\n";
if (defined $nixpkgsPath) {
system("nix-env", "-p", "$profileDir/system",
"-I", "nixos-config=$nixosConfigFile", "-I", "nixpkgs=$nixpkgsPath",

This comment has been minimized.

@bjornfor

bjornfor Nov 16, 2019
Contributor

It seems unfortunate to duplicate this block only to add one option. Can you try deduplicating it?

This comment has been minimized.

@greydot

greydot Nov 16, 2019
Author Contributor

I considered this, but I'm not very familiar with Perl. Does it allow putting a function's arguments into an array and then passing that? Similar to Python's f(*args).

This comment has been minimized.

@greydot

greydot Nov 16, 2019
Author Contributor

Ok, got this done as an args array.

@FRidh
Copy link
Member

@FRidh FRidh commented Nov 16, 2019

nixpkgs-path seems unnecessary specific. If you want to support this, then I am of the opinion it should listen to NIX_PATH instead. That makes me wonder also, why does it not have the same UI as other Nix tools with regard to NIX_PATH or -I?

@greydot
Copy link
Contributor Author

@greydot greydot commented Nov 16, 2019

nixpkgs-path seems unnecessary specific. If you want to support this, then I am of the opinion it should listen to NIX_PATH instead. That makes me wonder also, why does it not have the same UI as other Nix tools with regard to NIX_PATH or -I?

Generalizing this and nixos-path into passing arbitrary -I paths is a nice idea, but it would break compatibility. Do we want that?

@greydot greydot force-pushed the greydot:nixos-container branch from b5ce8b0 to 92b16d2 Nov 16, 2019
This commit adds --nixpkgs-path option to create and update operations, allowing
the use of custom nixpkgs repos.
@greydot greydot force-pushed the greydot:nixos-container branch from 92b16d2 to 2eb2da5 Nov 19, 2019
@stale
Copy link

@stale stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.