Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weechatScripts.weechat-matrix: init at unstable-2019-11-10 #73460

Merged
merged 4 commits into from Nov 17, 2019

Conversation

@tilpner
Copy link
Member

@tilpner tilpner commented Nov 15, 2019

Motivation for this change

This migrates the package from my NUR package set, as multiple people have attempted to repackage it due to poor visibility of NUR packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

@clefru, @zfnmxt, @redvers, @gjabell: Please test this

tilpner added 2 commits Nov 15, 2019
@tilpner
Copy link
Member Author

@tilpner tilpner commented Nov 15, 2019

@GrahamcOfBorg build weechatScripts.weechat-matrix

Copy link
Contributor

@gjabell gjabell left a comment

Works for me! Would it be possible to wrap the contrib/matrix_upload (see here) script?

@tilpner tilpner force-pushed the tilpner:pkgs/weechat-matrix/init branch from db95724 to 35cd0a9 Nov 15, 2019
@tilpner
Copy link
Member Author

@tilpner tilpner commented Nov 15, 2019

@gjabell I've added the matrix_upload script, and uploading seems to work if weechat-matrix is installed so that weechat has it in PATH.

@clefru
Copy link
Contributor

@clefru clefru commented Nov 15, 2019

@tilpner Works for me! Thank you so much for putting this together :)

@zfnmxt
Copy link
Contributor

@zfnmxt zfnmxt commented Nov 16, 2019

Works great for me. Thanks a lot. Surprised you even remember me asking about this on #nixos. :)

Copy link
Contributor

@jonringer jonringer left a comment

otherwise LGTM

@dtzWill dtzWill mentioned this pull request Nov 16, 2019
3 of 10 tasks complete
tilpner added 2 commits Nov 15, 2019
@tilpner tilpner force-pushed the tilpner:pkgs/weechat-matrix/init branch from 35cd0a9 to 8efa73b Nov 16, 2019
@tilpner
Copy link
Member Author

@tilpner tilpner commented Nov 16, 2019

@jonringer Thank you, I pushed changes to address your comments.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 17, 2019

@GrahamcOfBorg build weechatScripts.weechat-matrix

Copy link
Contributor

@jonringer jonringer left a comment

nix-reveiw passes on NixOS (1 python38 failure, but that's an upstream issue)
diff LGTM

[1 built (1 failed), 7 copied (49.8 MiB), 10.0 MiB DL]
error: build of '/nix/store/pfs6cdd27064rrldxvl0s982jwb84p6m-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/73460
1 package failed to build:
python38Packages.matrix-nio

9 package were build:
matrique mtxclient nheko olm purple-matrix python27Packages.python-olm python37Packages.matrix-nio python37Packages.python-olm python38Packages.python-olm
@@ -1,10 +1,12 @@
{ callPackage, luaPackages }:
{ callPackage, luaPackages, python3Packages }:

This comment has been minimized.

@jonringer

jonringer Nov 17, 2019
Contributor

this should probably be python and in all-packages this should be passed python = python3; then use python.pkgs.callPackage; but I don't feel strongly enough about that to require a change.

@jonringer jonringer merged commit 8150b58 into NixOS:master Nov 17, 2019
18 checks passed
18 checks passed
weechatScripts.weechat-matrix on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
olm on aarch64-linux Success
Details
olm on x86_64-linux Success
Details
weechatScripts.weechat-matrix on aarch64-linux Success
Details
weechatScripts.weechat-matrix on x86_64-linux Success
Details
@tilpner tilpner deleted the tilpner:pkgs/weechat-matrix/init branch Nov 17, 2019
@tilpner tilpner restored the tilpner:pkgs/weechat-matrix/init branch Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.