Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pplatex: init at unstable-2015-09-14 #73461

Merged
merged 5 commits into from Nov 15, 2019
Merged

pplatex: init at unstable-2015-09-14 #73461

merged 5 commits into from Nov 15, 2019

Conversation

@SRGOM
Copy link
Member

@SRGOM SRGOM commented Nov 15, 2019

Motivation for this change

Tired of unreadable TeX errors, pplatex pretty prints them and makes them (actually) readable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)

  • Built on platform(s)

    • [x]NixOS
    • macOS
    • [ ]other Linux distributions
  • Tested execution of all binary files (usually in ./result/bin/)

  • Fits CONTRIBUTING.md.

Notify maintainers

cc @SRGOM

Copy link
Member

@veprbl veprbl left a comment

Any particular reason to have your commit signing with a different github user?

pkgs/tools/typesetting/tex/pplatex/default.nix Outdated Show resolved Hide resolved
pkgs/tools/typesetting/tex/pplatex/default.nix Outdated Show resolved Hide resolved
pkgs/tools/typesetting/tex/pplatex/default.nix Outdated Show resolved Hide resolved
pkgs/tools/typesetting/tex/pplatex/default.nix Outdated Show resolved Hide resolved
pkgs/tools/typesetting/tex/pplatex/default.nix Outdated Show resolved Hide resolved
pkgs/tools/typesetting/tex/pplatex/default.nix Outdated Show resolved Hide resolved
pkgs/tools/typesetting/tex/pplatex/default.nix Outdated Show resolved Hide resolved
pkgs/tools/typesetting/tex/pplatex/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@SRGOM
Copy link
Member Author

@SRGOM SRGOM commented Nov 15, 2019

Any particular reason to have your commit signing with a different github user?

I have no clue where that username came from. I've grepped the global and local git config ... I use very short names, 2-5 chars, so that's definitely not me.

@SRGOM
Copy link
Member Author

@SRGOM SRGOM commented Nov 15, 2019

I've addressed all comments ...

_ and others added 2 commits Nov 15, 2019
@veprbl veprbl self-assigned this Nov 15, 2019
veprbl added 3 commits Nov 15, 2019
@veprbl
Copy link
Member

@veprbl veprbl commented Nov 15, 2019

@GrahamcOfBorg build pplatex

@SRGOM
Copy link
Member Author

@SRGOM SRGOM commented Nov 15, 2019

Did you remove linux deliberately? Or you only intended to add darwin?

@veprbl
Copy link
Member

@veprbl veprbl commented Nov 15, 2019

@SRGOM Yes, it was by mistake.

@veprbl
veprbl approved these changes Nov 15, 2019
@veprbl veprbl merged commit d587092 into NixOS:master Nov 15, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
pplatex on aarch64-linux Success
Details
pplatex on x86_64-darwin Success
Details
pplatex on x86_64-linux Success
Details
@veprbl
Copy link
Member

@veprbl veprbl commented Nov 15, 2019

@SRGOM Thanks!

@veprbl veprbl removed their assignment Nov 15, 2019
@SRGOM
Copy link
Member Author

@SRGOM SRGOM commented Nov 15, 2019

Thank you for the review and approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.