Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.archinfo: init at 8.19.10.30 #73464

Closed
wants to merge 1 commit into from

Conversation

@Pamplemousse
Copy link
Member

@Pamplemousse Pamplemousse commented Nov 15, 2019

Motivation for this change

Making progress on #67413 : archinfo is one of the component of angr.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.
{ buildPythonPackage
, fetchFromGitHub
, nose
, pkgs

This comment has been minimized.

@jonringer

jonringer Nov 15, 2019
Contributor

Suggested change
, pkgs
, lib
nosetests tests/
'';

meta = with pkgs.lib; {

This comment has been minimized.

@jonringer

jonringer Nov 15, 2019
Contributor

Suggested change
meta = with pkgs.lib; {
meta = with lib; {
@@ -181,6 +181,8 @@ in {

argon2_cffi = callPackage ../development/python-modules/argon2_cffi { };

archinfo = disabledIf (!isPy3k) (callPackage ../development/python-modules/archinfo { });

This comment has been minimized.

@jonringer

jonringer Nov 15, 2019
Contributor

please move disable logic into expression

Suggested change
archinfo = disabledIf (!isPy3k) (callPackage ../development/python-modules/archinfo { });
archinfo = disabledIf (!isPy3k) (callPackage ../development/python-modules/archinfo { });

buildPythonPackage rec {
pname = "archinfo";
version = "8.19.10.30";

This comment has been minimized.

@jonringer

jonringer Nov 15, 2019
Contributor

Suggested change
version = "8.19.10.30";
version = "8.19.10.30";
disabled = !isPy3k;
@Pamplemousse
Copy link
Member Author

@Pamplemousse Pamplemousse commented Dec 6, 2019

I started https://github.com/angr/nixpkgs , and it should be added to NUR following nix-community/NUR#160.
Closed as an angr related package.

@Pamplemousse Pamplemousse deleted the Pamplemousse:archinfo branch Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.