Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lazygit: 0.8 -> 0.10.6 #73471

Closed
wants to merge 7 commits into from

Conversation

@equirosa
Copy link
Contributor

equirosa commented Nov 15, 2019

Motivation for this change

Current version of lazygit is slightly outdated.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @fpletz

@JohnAZoidberg

This comment has been minimized.

Copy link
Member

JohnAZoidberg commented Nov 16, 2019

Also please squash the commits together, make sure everything fits CONTRIBUTING.md and tick that last box.

For next time: It's nice to include a link to the new release and/or changelog in "Motivation" :)

@equirosa

This comment has been minimized.

Copy link
Contributor Author

equirosa commented Nov 16, 2019

Also please squash the commits together, make sure everything fits CONTRIBUTING.md and tick that last box.

For next time: It's nice to include a link to the new release and/or changelog in "Motivation" :)

Got it! Will fix ASAP :)

equirosa and others added 5 commits Nov 21, 2019
Co-Authored-By: Daniel Schaefer <git@danielschaefer.me>
@equirosa equirosa closed this Dec 3, 2019
@JohnAZoidberg

This comment has been minimized.

Copy link
Member

JohnAZoidberg commented Dec 3, 2019

Why closed? Would you like to update it to 0.11.3.

@equirosa

This comment has been minimized.

Copy link
Contributor Author

equirosa commented Dec 3, 2019

Why closed? Would you like to update it to 0.11.3.

It was the first time having to make some changes to a pull request so I thought to make a new one since the version change was different. Kinda new to this...

@JohnAZoidberg

This comment has been minimized.

Copy link
Member

JohnAZoidberg commented Dec 4, 2019

Did you make a new one? Please link to it here.
No, you don't have to make a new one. It's perfectly fine, to continue here. Just use make your changes (even rewriting old commits) and git push --force. :)

@equirosa

This comment has been minimized.

Copy link
Contributor Author

equirosa commented Dec 4, 2019

Did you make a new one? Please link to it here.
No, you don't have to make a new one. It's perfectly fine, to continue here. Just use make your changes (even rewriting old commits) and git push --force. :)

Oh, ok! Thanks for your help! 😄
And here's the other one I made: #74895

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.