Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blugon: init at 1.11.4 #73476

Merged
merged 1 commit into from Nov 17, 2019
Merged

blugon: init at 1.11.4 #73476

merged 1 commit into from Nov 17, 2019

Conversation

@jumper149
Copy link
Contributor

jumper149 commented Nov 16, 2019

Motivation for this change

Adding a new application.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date (there is only metadata)
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Copy link
Member

JohnAZoidberg left a comment

Thanks for your contribution! :)

Tested and it seems to work.
Is the filter supposed to stay after I kill the program?
Got my natural color back with blugon --setcurrent=6600.0

pkgs/applications/misc/blugon/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/blugon/default.nix Outdated Show resolved Hide resolved
@jumper149

This comment has been minimized.

Copy link
Contributor Author

jumper149 commented Nov 16, 2019

Is the filter supposed to stay after I kill the program?
Got my natural color back with blugon --setcurrent=6600.0

Yes this just the way it's intended to be!

@jumper149

This comment has been minimized.

Copy link
Contributor Author

jumper149 commented Nov 17, 2019

I used git rebase to fixup the previous commit.

@jumper149 jumper149 requested a review from JohnAZoidberg Nov 17, 2019
Copy link
Member

JohnAZoidberg left a comment

Some minor things, then it should be okay :)

pkgs/applications/misc/blugon/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/blugon/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/blugon/default.nix Outdated Show resolved Hide resolved
@jumper149 jumper149 requested a review from JohnAZoidberg Nov 17, 2019
@ryantm ryantm merged commit 30fa836 into NixOS:master Nov 17, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
blugon on aarch64-linux Success
Details
blugon on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ryantm

This comment has been minimized.

Copy link
Member

ryantm commented Nov 17, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.