Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keybase, keybase-gui: 4.7.2 -> 5.0.0; add dependence, license #73480

Merged
merged 3 commits into from Nov 17, 2019

Conversation

@judaew
Copy link
Contributor

judaew commented Nov 16, 2019

Motivation for this change

Update from 4.7.2 to 5.0.0 and add libappindicator-gtk for keybase-gui

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

judaew and others added 2 commits Nov 16, 2019
See #72147
See issue: #43716
@judaew judaew changed the title keybase, keybase-gui: 4.7.2 -> 5.0.0 and add dependence keybase, keybase-gui: 4.7.2 -> 5.0.0; add dependence, license Nov 17, 2019
@ryantm
ryantm approved these changes Nov 17, 2019
Copy link
Member

ryantm left a comment

nix-review pr passed; both binaries work on NixOS for me

thanks!

@ryantm ryantm merged commit 2c7d994 into NixOS:master Nov 17, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
keybase, keybase-gui on aarch64-linux Success
Details
keybase, keybase-gui on x86_64-linux Success
Details
@judaew

This comment has been minimized.

Copy link
Contributor Author

judaew commented Nov 17, 2019

You are welcome 🌟!

@judaew

This comment has been minimized.

Copy link
Contributor Author

judaew commented Nov 17, 2019

@ryantm Please close this pull request #72147 . The commit has been moved here and the change is already merged.

@ryantm ryantm mentioned this pull request Nov 17, 2019
3 of 10 tasks complete
@judaew judaew deleted the judaew:keybase-update branch Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.