Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Motivation for this change
Added some fixups I've apparently been sitting on since June? Anyway the first installs the vym manpage, the second fixes some strange installation into $out/vym as well as patches around hardcoded references to
As for the PR before those commits: please modify the commit message to adhere to the guidelines... the PR title is the right text :). I didn't make this change to avoid force-pushing to your branch w/o discussion at least :).
No need for worrying about wrapping ourselves, that's why this uses mkDerivation from the qt set.
From the manual you linked:
On the other hand,
That's good to know, and we should probably use the version upstream marks ready and stable :).
If you don't mind, can you link or point me to where they say 2.7.1 isn't ready? Sorry for missing it!
On a whim checked repology.org stats and looks like I'm not the only one who missed the memo:
Ok. I'm sorry, if I caused any hassle.
Concerning that I only have a screenshot of the release notes window, which pops up after starting vym the first time:
On Sun, 17 Nov 2019 09:46:33 -0800, rys ostrovid ***@***.***> wrote: > > Please add also `wrapQtAppsHook` in `nativeBuildInputs` or the executable probably won't run properly. The underlying issue is described in [this manual section](https://hydra.nixos.org/build/96804884/download/1/nixpkgs/manual.html#sec-language-qt). > > No need for worrying about wrapping ourselves, that's why this uses mkDerivation from the qt set. > > From the manual you linked: > > > . If you cannot use mkDerivation or mkDerivationWith above, include wrapQtAppsHook Ok. I'm sorry, if I caused any hassle.
Not at all, we're all trying to ensure this works well for everyone :).
Concerning that I only have a screenshot of the release notes window, which pops up after starting vym the first time: ![vym_unstable](https://user-images.githubusercontent.com/1859691/69011417-6db54100-096a-11ea-869b-e78851a3330c.png)
!! Wow--so I grabbed the update in June (eep sorry for not seeing it into a PR myself, and sooner!) so I very likely completely forgot about this message. I poked at the code repository, and indeed v2.7.0 is tagged but there's no 2.7.1 tag?? (what code is in that tarball?! haha) Thanks for bringing this up-- sounds like we should be on 2.7.0!…
-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #73483 (comment) part: text/html
I should add that when choosing 2.7.1 I just picked the latest version from sourceforge. There was no indication that it was a development version (and there is a folder for development releases that this was not in). I noticed that 2.7.1 only comes as a tarball without releases for Windows, so I assumed it was a minor version that contained a Linux-specific bug fix.
Also in the "About" window, the version is listed as 2.7.500 - 2019-05-08
I'm fine switching to whatever version we can agree is the latest stable.