Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teamspeak-client: fix stuck build #73485

Merged
merged 1 commit into from Nov 16, 2019
Merged

Conversation

@cleverca22
Copy link
Contributor

cleverca22 commented Nov 16, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@cleverca22 cleverca22 requested a review from Infinisil Nov 16, 2019
@cleverca22 cleverca22 mentioned this pull request Nov 16, 2019
5 of 10 tasks complete
@lovesegfault

This comment has been minimized.

Copy link
Contributor

lovesegfault commented Nov 16, 2019

Looks good over here!

❯ nix-shell -p nix-review --run 'nix-review pr 73485'
these paths will be fetched (0.03 MiB download, 0.10 MiB unpacked):
  /nix/store/m248jqzwk93vbx16p9ap353bj3p5d567-nix-review-2.0.1
copying path '/nix/store/m248jqzwk93vbx16p9ap353bj3p5d567-nix-review-2.0.1' from 'https://cache.nixos.org'...
$ git fetch --force https://github.com/NixOS/nixpkgs release-19.09:refs/nix-review/0 pull/73485/head:refs/nix-review/1
remote: Enumerating objects: 6, done.
remote: Counting objects: 100% (6/6), done.
remote: Total 6 (delta 5), reused 6 (delta 5), pack-reused 0
Unpacking objects: 100% (6/6), done.
From https://github.com/NixOS/nixpkgs
 + abdc1eaed21...9104be2ee08 release-19.09        -> refs/nix-review/0  (forced update)
 + c66835b42ae...3efadb07287 refs/pull/73485/head -> refs/nix-review/1  (forced update)
$ git worktree add /home/bemeurer/.cache/nix-review/pr-73485/nixpkgs 9104be2ee08f2fea20e0809ac667a99f2c37582b
Preparing worktree (detached HEAD 9104be2ee08)
Updating files: 100% (19843/19843), done.
HEAD is now at 9104be2ee08 nextcloud: 16.0.5 -> 16.0.6
$ nix-env -f /home/bemeurer/.cache/nix-review/pr-73485/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit 3efadb072876b1a55f9ce98c2e13d78d2e769626
Updating 9104be2ee08..3efadb07287
Fast-forward
 pkgs/applications/networking/instant-messengers/teamspeak/client.nix | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
$ nix-env -f /home/bemeurer/.cache/nix-review/pr-73485/nixpkgs -qaP --xml --out-path --show-trace --meta
$ nix build --no-link --keep-going --max-jobs 12 --option build-use-sandbox true -f /home/bemeurer/.cache/nix-review/pr-73485/build.nix
[6 built, 192 copied (888.1 MiB), 189.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73485
1 package were build:
teamspeak_client

[0.0 MiB DL]
$ nix-shell /home/bemeurer/.cache/nix-review/pr-73485/shell.nix
@ofborg ofborg bot requested a review from nathanielbaxter Nov 16, 2019
@Mic92 Mic92 merged commit 93633bb into NixOS:release-19.09 Nov 16, 2019
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@cleverca22 cleverca22 deleted the cleverca22:fix-19.09-teamspeak branch Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.