Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit: 1.12.0 -> 1.13.0 #73491

Merged
merged 3 commits into from Dec 5, 2019
Merged

unit: 1.12.0 -> 1.13.0 #73491

merged 3 commits into from Dec 5, 2019

Conversation

@Izorkin
Copy link
Contributor

Izorkin commented Nov 16, 2019

Motivation for this change

Update nginx unit to version 1.13.0

Changelog:

  • Feature: basic support for HTTP reverse proxying.
  • Feature: compatibility with Python 3.8.
  • Bugfix: memory leak in Python application processes when the close handler was used.
  • Bugfix: threads in Python applications might not work correctly.
  • Bugfix: Ruby on Rails applications might not work on Ruby 2.6.
  • Bugfix: backtraces for uncaught exceptions in Python 3 might be logged with significant delays.
  • Bugfix: explicit setting a namespaces isolation option to false might have enabled it.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Izorkin Izorkin force-pushed the Izorkin:unit branch from 64f9281 to 196023f Nov 17, 2019
@Izorkin Izorkin requested review from alyssais and zimbatm as code owners Nov 17, 2019
@Izorkin

This comment has been minimized.

Copy link
Contributor Author

Izorkin commented Nov 17, 2019

Added commit to fix this error:
nginx/unit#349
#73513

@alyssais

This comment has been minimized.

Copy link
Member

alyssais commented Nov 17, 2019

@Izorkin

This comment has been minimized.

Copy link
Contributor Author

Izorkin commented Nov 17, 2019

https://www.speedshop.co/2018/03/28/nginx-unit-for-ruby.html - ruby application server.

For example, if need to run applications, one of which supports version 2.4, and the other application only 2.6

Copy link
Member

ryantm left a comment

Since this involves hundreds of rebuilds it should probably target the staging branch.

@Izorkin Izorkin force-pushed the Izorkin:unit branch from 80d2573 to 97dae65 Nov 18, 2019
@Izorkin Izorkin changed the base branch from master to staging Nov 18, 2019
@Izorkin

This comment has been minimized.

Copy link
Contributor Author

Izorkin commented Nov 18, 2019

Rebased to staging.

@Izorkin

This comment has been minimized.

Copy link
Contributor Author

Izorkin commented Nov 18, 2019

@ryantm
ryantm approved these changes Nov 18, 2019
@Izorkin Izorkin force-pushed the Izorkin:unit branch from cec930a to 1a661f2 Nov 18, 2019
@FRidh FRidh added this to Ready in Staging Nov 19, 2019
pkgs/servers/http/unit/default.nix Outdated Show resolved Hide resolved
@Izorkin Izorkin force-pushed the Izorkin:unit branch from 1a661f2 to 7d0fcb8 Nov 24, 2019
@FRidh FRidh self-requested a review Dec 5, 2019
@FRidh FRidh merged commit 353ec3f into NixOS:staging Dec 5, 2019
16 checks passed
16 checks passed
ruby, unit on x86_64-darwin Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
ruby, unit on aarch64-linux Success
Details
ruby, unit on x86_64-linux Success
Details
Staging automation moved this from Ready to Done Dec 5, 2019
@Izorkin Izorkin deleted the Izorkin:unit branch Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.