Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weechatScripts: recurseIntoAttrs #73495

Merged
merged 1 commit into from May 9, 2020

Conversation

@tilpner
Copy link
Member

tilpner commented Nov 16, 2019

Motivation for this change

In 8f86439 @oxij marked the weechatScripts set as dontRecurseIntoAttrs.

That didn't really change anything, just made it more explicit that those attributes are not traversed.

This seems to cause @GrahamcOfBorg to not detect and test changes to these outputs, like in #73460.

I don't know the policy on when (not) to use recurseIntoAttrs, so this is a question worded as a PR.

Copy link
Contributor

jonringer left a comment

nix-review passes on NixOS
diff LGTM

[16 built, 7 copied (3.2 MiB), 0.7 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73495
4 package were build:
weechatScripts.wee-slack weechatScripts.weechat-autosort weechatScripts.weechat-matrix-bridge weechatScripts.weechat-otr

going to wait for someone who is more opinionated to weigh in

@oxij
Copy link
Contributor

oxij commented Nov 17, 2019

@jonringer
Copy link
Contributor

jonringer commented Nov 17, 2019

@GrahamcOfBorg build weechatScripts

curious if it will build an attr set

@Mic92 Mic92 merged commit a84f932 into NixOS:master May 9, 2020
16 checks passed
16 checks passed
weechatScripts on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
weechatScripts on aarch64-linux Success
Details
weechatScripts on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.