Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weechatScripts: recurseIntoAttrs #73495

Open
wants to merge 1 commit into
base: master
from

Conversation

@tilpner
Copy link
Member

tilpner commented Nov 16, 2019

Motivation for this change

In 8f86439 @oxij marked the weechatScripts set as dontRecurseIntoAttrs.

That didn't really change anything, just made it more explicit that those attributes are not traversed.

This seems to cause @GrahamcOfBorg to not detect and test changes to these outputs, like in #73460.

I don't know the policy on when (not) to use recurseIntoAttrs, so this is a question worded as a PR.

@tilpner

This comment has been minimized.

Copy link
Contributor

jonringer left a comment

nix-review passes on NixOS
diff LGTM

[16 built, 7 copied (3.2 MiB), 0.7 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73495
4 package were build:
weechatScripts.wee-slack weechatScripts.weechat-autosort weechatScripts.weechat-matrix-bridge weechatScripts.weechat-otr

going to wait for someone who is more opinionated to weigh in

@oxij

This comment has been minimized.

Copy link
Contributor

oxij commented Nov 17, 2019

@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Nov 17, 2019

@GrahamcOfBorg build weechatScripts

curious if it will build an attr set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.