Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd-networkd: add DHCPServer test #73505

Open
wants to merge 2 commits into
base: master
from

Conversation

@tomfitzhenry
Copy link
Contributor

tomfitzhenry commented Nov 16, 2019

Motivation for this change
  • Demonstrate #73504
  • Stop such regressions happening in future.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Copy link
Member

prusnak left a comment

Tests are being written in Python now, see #72828

nixos/tests/systemd-networkd-dhcpserver.nix Outdated Show resolved Hide resolved
@tomfitzhenry tomfitzhenry force-pushed the tomfitzhenry:networkd-dhcp-server-test branch 3 times, most recently from b3e386a to 186acfc Nov 17, 2019
@tomfitzhenry tomfitzhenry requested a review from prusnak Nov 17, 2019
Copy link
Contributor

flokli left a comment

IIRC, there were some problems with useNetworkd in nixos vm tests, due to some assumptions in the testing infrastructure. @fpletz, @arianvp, can you take a look?

nixos/tests/systemd-networkd-dhcpserver.nix Outdated Show resolved Hide resolved
PoolOffset = 100;
PoolSize = 1;
# Workaround https://github.com/NixOS/nixpkgs/issues/73504
EmitTimezone = false;

This comment has been minimized.

Copy link
@flokli

flokli Nov 17, 2019

Contributor

Do we want to wait for upstream to fix this in systemd/systemd#14010 (comment) ? I'm afraid we might forget removing that line once it's fixed upstream…

This comment has been minimized.

Copy link
@tomfitzhenry

tomfitzhenry Nov 17, 2019

Author Contributor

I'm happy to wait for #73504 to be resolved.

@tomfitzhenry

This comment has been minimized.

Copy link
Contributor Author

tomfitzhenry commented Nov 17, 2019

IIRC, there were some problems with useNetworkd in nixos vm tests, due to some assumptions in the testing infrastructure.

I did spend an unreasonable amount of time battling with the per-VLAN networks that the test infrastructure adds by default, but eventually found the solution of picking a lexiographically smaller unit file name, which:

  • works, by allowing me to override the default networks
  • is documented in the test
  • is small/simple enough to not impose a large maintenance burden.
@tomfitzhenry tomfitzhenry force-pushed the tomfitzhenry:networkd-dhcp-server-test branch from 186acfc to 8c666dd Nov 17, 2019
@tomfitzhenry

This comment has been minimized.

Copy link
Contributor Author

tomfitzhenry commented Dec 4, 2019

This is blocked on #74207

@flokli flokli mentioned this pull request Dec 6, 2019
2 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.