Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.09] steam: use 32bit version of libva #73512

Merged
merged 1 commit into from Nov 19, 2019

Conversation

@jonringer
Copy link
Contributor

jonringer commented Nov 16, 2019

Motivation for this change

backport of #73481

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

(cherry picked from commit 87c674d)
@jonringer jonringer changed the title steam: use 32bit version of libva [19.09] steam: use 32bit version of libva Nov 16, 2019
@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Nov 16, 2019

not really able to verify that the 19.09 package is broken, I think the FHSenv is stateful, and don't know how to clear it completely from my computer

@aanderse

This comment has been minimized.

Copy link
Contributor

aanderse commented Nov 17, 2019

Not sure what to say @jonringer... Sorry for merging the previous PR I guess. I tested the previous PR and it fixed my broken steam. Kids were happy. I thought we had a winner...

Mildly curious what the issue is.

@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Nov 17, 2019

I think it was another update. and they verified it was a 32bit version

@nixos-discourse

This comment has been minimized.

Copy link

nixos-discourse commented Nov 19, 2019

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/steam-cannot-update/4848/2

@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Nov 19, 2019

got confirmation that it's broken, merging :)

@jonringer jonringer merged commit 40fcdac into NixOS:release-19.09 Nov 19, 2019
16 checks passed
16 checks passed
steam on aarch64-linux No attempt
Details
steam on x86_64-darwin No attempt
Details
steam on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jonringer jonringer deleted the jonringer:fix-steam-release branch Nov 19, 2019
@andir

This comment has been minimized.

Copy link
Member

andir commented Jan 20, 2020

I have a case where this seems to have broken a game. "DOTA Underlords" seems to expect a 64bit version of libva.so but now with this commit merged it fails to start. I guess if we just add the other lib it clashes? What are our options? Is there some way to have 32bit only LD_LIBRARY_PATH that contains those libs needed for 32bit systems?

@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Jan 21, 2020

That's interesting, as steam won't launch if this is missing. It might be possible to have both present. But I'm not sure

@andir

This comment has been minimized.

Copy link
Member

andir commented Jan 21, 2020

Steam did launch after reverting this. I am not entirely sure what is going on :/

@megfault

This comment has been minimized.

Copy link

megfault commented Jan 22, 2020

I had that issue with Dota Underlords, reverted this commit and could finally launch the game. Steam is working fine.

@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Jan 22, 2020

It's a FTP game, I'll try myself

This was referenced Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.