Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rasm: init at 0.117 #73518

Merged
merged 1 commit into from Dec 16, 2019
Merged

rasm: init at 0.117 #73518

merged 1 commit into from Dec 16, 2019

Conversation

@bignaux
Copy link
Contributor

bignaux commented Nov 16, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

pkgs/development/compilers/rasm/default.nix Outdated Show resolved Hide resolved

src = fetchurl {
name = "rasm_v0116_src.zip";
url = "http://www.cpcwiki.eu/forum/programming/rasm-z80-assembler-in-beta/?action=dlattach;attach=30015";

This comment has been minimized.

Copy link
@jonringer

jonringer Nov 17, 2019

Contributor

is there a more official url, other than some download links on a forum? Would be nice if he/she had a github/gitlab, especially seeing as it's mit license anyway.

This comment has been minimized.

Copy link
@bignaux

bignaux Nov 17, 2019

Author Contributor

it's the official url according http://www.roudoudou.com/rasm/ . If i've time i would contact author but you know, most of time, such people doesn't work with git and has no opensource culture. BTW I'll try later since it's a compatriot.

pkgs/development/compilers/rasm/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/rasm/default.nix Outdated Show resolved Hide resolved
@bignaux bignaux force-pushed the bignaux:rasm branch from 5989a2c to 561961e Nov 17, 2019
@bignaux

This comment has been minimized.

Copy link
Contributor Author

bignaux commented Dec 14, 2019

I'd contacted the author, btw he changed src file without let old or change url so this could not work.

@bignaux bignaux force-pushed the bignaux:rasm branch from 561961e to 69b55de Dec 16, 2019
@bignaux

This comment has been minimized.

Copy link
Contributor Author

bignaux commented Dec 16, 2019

src.url fixed with the help of the author.

@bignaux bignaux changed the title rasm: init at 0.116 rasm: init at 0.117 Dec 16, 2019
Copy link
Contributor

jonringer left a comment

diff LGTM
commit LGTM

[3 built, 53 copied (233.6 MiB), 55.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73518
1 package were built:
rasm
@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Dec 16, 2019

@GrahamcOfBorg build rasm

@jonringer jonringer merged commit 3ad650a into NixOS:master Dec 16, 2019
15 of 16 checks passed
15 of 16 checks passed
rasm on x86_64-linux
Details
rasm on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
rasm on aarch64-linux Success
Details
@bignaux bignaux deleted the bignaux:rasm branch Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.