Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/nvidia: include systemd power management #73530

Merged
merged 1 commit into from May 12, 2020
Merged

Conversation

@eadwu
Copy link
Member

eadwu commented Nov 17, 2019

Motivation for this change

#73494

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

nixos/modules/hardware/video/nvidia.nix Outdated Show resolved Hide resolved
nixos/modules/hardware/video/nvidia.nix Outdated Show resolved Hide resolved
@eadwu eadwu force-pushed the eadwu:nvidia/systemd-pm branch 2 times, most recently from dee70c0 to 6f6746f Nov 17, 2019
@eadwu eadwu force-pushed the eadwu:nvidia/systemd-pm branch 2 times, most recently from 325dcf5 to ee94f3b Nov 17, 2019
@eadwu eadwu force-pushed the eadwu:nvidia/systemd-pm branch from ee94f3b to 9d09bb3 Nov 21, 2019
@eadwu eadwu marked this pull request as ready for review Nov 26, 2019
@lovesegfault
Copy link
Contributor

lovesegfault commented Feb 28, 2020

What's the status on this @eadwu @flokli?

@eadwu
Copy link
Member Author

eadwu commented Mar 1, 2020

I'm waiting for #66601 to get merged before pushing for this since it will introduce conflicts.

Doesn't seem anyone is having critical issues with NVIDIA to push for this right now.

@eadwu eadwu force-pushed the eadwu:nvidia/systemd-pm branch from 9d09bb3 to 7d5b1ec Mar 2, 2020
@eadwu eadwu force-pushed the eadwu:nvidia/systemd-pm branch from 7d5b1ec to f51e573 Apr 7, 2020
@eadwu eadwu force-pushed the eadwu:nvidia/systemd-pm branch from f51e573 to fae0c20 May 10, 2020
@eadwu eadwu force-pushed the eadwu:nvidia/systemd-pm branch from fae0c20 to 9a269f5 May 10, 2020
@flokli flokli requested a review from lovesegfault May 11, 2020
@Mic92
Copy link
Contributor

Mic92 commented May 11, 2020

#66601 is merged now.

Experimental power management through systemd. For more information, see
the NVIDIA docs, on Chapter 21. Configuring Power Management Support.
Comment on lines +59 to +60

This comment has been minimized.

Copy link
@lovesegfault

lovesegfault May 11, 2020

Contributor

If these docs are publicly available, then a link would be nice.

This comment has been minimized.

Copy link
@eadwu

eadwu May 11, 2020

Author Member

The docs are within each package, so pinning the doc has the possibility of the docs becoming outdated (I'm not sure if there's a link for the "latest" package).

Then again, I could probably do something along the lines of https://download.nvidia.com/XFree86/Linux-x86_64/${nvidia_x11.version}/README/powermanagement.html but not sure if a package evaluation should be done just for the option.

This comment has been minimized.

Copy link
@lovesegfault

lovesegfault May 11, 2020

Contributor

Fair :)

Copy link
Contributor

lovesegfault left a comment

:shipit:

@flokli flokli merged commit d6f90e4 into NixOS:master May 12, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9a269f5"; rev="9a269f555a644fae0298af304b007f8e96e6b14f"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9a269f5"; rev="9a269f555a644fae0298af304b007f8e96e6b14f"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9a269f5"; rev="9a269f555a644fae0298af304b007f8e96e6b14f"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9a269f5"; rev="9a269f555a644fae0298af304b007f8e96e6b14f"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9a269f5"; rev="9a269f555a644fae0298af304b007f8e96e6b14f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9a269f5"; rev="9a269f555a644fae0298af304b007f8e96e6b14f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9a269f5"; rev="9a269f555a644fae0298af304b007f8e96e6b14f"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.