Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quarte: use qt5’s mkDerivation and an other fix 19.09 backport #73547

Merged

Conversation

@ahiaao
Copy link
Contributor

@ahiaao ahiaao commented Nov 17, 2019

Motivation for this change

Cherry picked #67544 to fix https://hydra.nixos.org/build/106243976

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @vbgl

@ahiaao ahiaao requested a review from FRidh as a code owner Nov 17, 2019
@ahiaao ahiaao changed the title Qarte+fix qt platform backport quarte: use qt5’s mkDerivation and an other fix 19.09 backport Nov 17, 2019
@ofborg ofborg bot requested review from svanderburg and vbgl Nov 17, 2019
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Feb 1, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/112

vbgl added 2 commits Aug 27, 2019
See #65399

(cherry picked from commit e063d08)
Otherwise, qarte fails at run-time with:

>     from PyQt5.QtMultimedia import QMediaPlayer
> ModuleNotFoundError: No module named 'PyQt5.QtMultimedia'

(cherry picked from commit ef15478)
@ahiaao ahiaao force-pushed the ahiaao:qarte+fix-qt-platform-backport branch from 3e26139 to 723af8f Feb 2, 2020
@ahiaao
Copy link
Contributor Author

@ahiaao ahiaao commented Feb 2, 2020

@worldofpeace Resolved

@worldofpeace worldofpeace merged commit 10e175a into NixOS:release-19.09 Feb 2, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
qarte on aarch64-linux Success
Details
qarte on x86_64-linux Success
Details
@ahiaao ahiaao deleted the ahiaao:qarte+fix-qt-platform-backport branch Feb 18, 2020
@ahiaao ahiaao restored the ahiaao:qarte+fix-qt-platform-backport branch Feb 18, 2020
@ahiaao ahiaao deleted the ahiaao:qarte+fix-qt-platform-backport branch Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.