Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geoipupdate: Init at 4.1.5 #73578

Merged
merged 1 commit into from Nov 19, 2019
Merged

geoipupdate: Init at 4.1.5 #73578

merged 1 commit into from Nov 19, 2019

Conversation

@dasJ
Copy link
Member

dasJ commented Nov 17, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@dasJ

This comment has been minimized.

Copy link
Member Author

dasJ commented Nov 17, 2019

See also #55867

pkgs/applications/misc/geoipupdate/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/geoipupdate/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/geoipupdate/default.nix Outdated Show resolved Hide resolved
@dasJ dasJ force-pushed the helsinki-systems:geoip-init branch 2 times, most recently from f057b43 to 2e9010c Nov 17, 2019
@dasJ

This comment has been minimized.

Copy link
Member Author

dasJ commented Nov 17, 2019

@prusnak Done

@dasJ dasJ force-pushed the helsinki-systems:geoip-init branch from 2e9010c to 956c2a5 Nov 17, 2019

meta = with stdenv.lib; {
description = "Automatic GeoIP database updater";
license = with licenses; [ asl20 ];

This comment has been minimized.

Copy link
@prusnak

prusnak Nov 17, 2019

Member

Sorry, one more :-/

homepage = "https://github.com/maxmind/geoipupdate";

This comment has been minimized.

Copy link
@dasJ

dasJ Nov 19, 2019

Author Member

I thought about that but I wasn't sure if this is really the homepage :/

This comment has been minimized.

Copy link
@jonringer

jonringer Nov 19, 2019

Contributor

It's just some way to link to the correct repo, as there may be other repos with the same name. github is commonly used as a landing page

@dasJ

This comment has been minimized.

Copy link
Member Author

dasJ commented Nov 17, 2019

Hash mismatches were due to me using the wrong callPackage while testing…

@dasJ

This comment has been minimized.

Copy link
Member Author

dasJ commented Nov 17, 2019

@GrahamcOfBorg build geoipupdate

@dasJ dasJ force-pushed the helsinki-systems:geoip-init branch from 956c2a5 to 35b50ca Nov 17, 2019
@dasJ

This comment has been minimized.

Copy link
Member Author

dasJ commented Nov 17, 2019

@jonringer Done

@dasJ dasJ mentioned this pull request Nov 17, 2019
3 of 10 tasks complete
@dasJ dasJ force-pushed the helsinki-systems:geoip-init branch from 35b50ca to 1f5a6bd Nov 18, 2019
@dasJ

This comment has been minimized.

Copy link
Member Author

dasJ commented Nov 18, 2019

@veprbl Done

Copy link
Contributor

jonringer left a comment

LGTM, please apply @prusnak suggestion :)

@dasJ dasJ force-pushed the helsinki-systems:geoip-init branch from 1f5a6bd to bc7f7cd Nov 19, 2019
@dasJ

This comment has been minimized.

Copy link
Member Author

dasJ commented Nov 19, 2019

Copy link
Contributor

jonringer left a comment

nix-review passes on NixOS
diff LGTM
commits LGTM
repo looks active enough

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73578
1 package were build:
geoipupdate
@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Nov 19, 2019

@GrahamcOfBorg build geoipupdate

@jonringer jonringer merged commit f06ca05 into NixOS:master Nov 19, 2019
15 of 16 checks passed
15 of 16 checks passed
geoipupdate on x86_64-linux
Details
Evaluation Performance Report Evaluator Performance Report
Details
geoipupdate on aarch64-linux Success
Details
geoipupdate on x86_64-darwin Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@dasJ dasJ deleted the helsinki-systems:geoip-init branch Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.