Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

valgrind: Add perl as a native build input #73606

Merged
merged 1 commit into from Dec 6, 2019

Conversation

@samueldr
Copy link
Member

@samueldr samueldr commented Nov 18, 2019

The changes in #67548 broke cross-compilation not for valgrind, but for
software relying on valgrind at build-time.

Motivation for this change

Building libdrm through cross-compilation fails.

../coregrind/link_tool_exe_linux: line 58: use: command not found
../coregrind/link_tool_exe_linux: line 59: use: command not found
../coregrind/link_tool_exe_linux: line 62: die: command not found
../coregrind/link_tool_exe_linux: line 70: syntax error near unexpected token `$ala'
../coregrind/link_tool_exe_linux: line 70: `    if (length($ala) < 3 || index($ala, "0x") != 0);'

This is perl being interpreted by the shell (bash).

Bisecting points to d22b485 being the breaking change.

I am not 100% sure that adding perl to both kind of buildInputs is the solution, are there any drawbacks, or dangers to doing so?

Things done
  • ✔️ Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • ✔️ NixOS
    • 🔲 macOS
    • 🔲 other Linux distributions
  • 🔲 Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • 🔲 Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • 🔲 Tested execution of all binary files (usually in ./result/bin/)
  • 🔲 Determined the impact on package closure size (by running nix path-info -S before and after)
  • ✔️ Ensured that relevant documentation is up to date
  • ✔️ Fits CONTRIBUTING.md.

cc @FRidh (who commented on the PR)
cc @Ericson2314 @matthewbauer (usual cross-compiling peeps)

The changes in #67548 broke cross-compilation not for valgrind, but for
software relying on valgrind at build-time.
@Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Nov 18, 2019

Having some packages as both types of dependency is perfectly fine. Carry on!

@FRidh FRidh added this to Needs review in Staging Nov 19, 2019
@flokli flokli merged commit 898e981 into NixOS:staging Dec 6, 2019
16 checks passed
16 checks passed
valgrind on x86_64-darwin Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
valgrind on aarch64-linux Success
Details
valgrind on x86_64-linux Success
Details
Staging automation moved this from Needs review to Done Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.