Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beets: fix absubmit deps #73608

Merged
merged 1 commit into from Nov 22, 2019
Merged

beets: fix absubmit deps #73608

merged 1 commit into from Nov 22, 2019

Conversation

@lovesegfault
Copy link
Contributor

@lovesegfault lovesegfault commented Nov 18, 2019

Motivation for this change

See #73589
TL;DR: Beets (tools/audio/beets) has a plugin called absubmit which relies on a statically linked binary provided by MusicBrainz.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @aszlig @domenkozar @pjones

@lovesegfault lovesegfault force-pushed the lovesegfault:beets-absubmit branch from 14069ee to ca7afd6 Nov 18, 2019
@lovesegfault lovesegfault force-pushed the lovesegfault:beets-absubmit branch from ca7afd6 to 82b0f74 Nov 18, 2019
@ofborg ofborg bot requested review from aszlig, pjones and domenkozar Nov 18, 2019
@aszlig
aszlig approved these changes Nov 18, 2019
Copy link
Member

@aszlig aszlig left a comment

Unfortunately I have limited time now, but from roughly skimming over it, the changes at least don't look harmful :-)

@domenkozar domenkozar removed their request for review Nov 19, 2019
@lovesegfault
Copy link
Contributor Author

@lovesegfault lovesegfault commented Nov 20, 2019

Pinging @pjones again

@lovesegfault
Copy link
Contributor Author

@lovesegfault lovesegfault commented Nov 22, 2019

Can someone please help me push this through, cc. @andir @pjones

Copy link
Member

@Infinisil Infinisil left a comment

LGTM!

@Infinisil Infinisil merged commit 9d3911f into NixOS:master Nov 22, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
beets on aarch64-linux Success
Details
beets on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@lovesegfault lovesegfault deleted the lovesegfault:beets-absubmit branch Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.