Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azcopy: 10.0.1 -> 10.3.2 #73613

Merged
merged 1 commit into from Dec 9, 2019
Merged

azcopy: 10.0.1 -> 10.3.2 #73613

merged 1 commit into from Dec 9, 2019

Conversation

@colemickens
Copy link
Member

@colemickens colemickens commented Nov 18, 2019

Upgrades azcopy to latest, uses buildGo112Module to work around issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@colemickens
Copy link
Member Author

@colemickens colemickens commented Nov 18, 2019

Note, at one point in 's history, this built with 10.3.1. I tested this PR with 10.3.1 as well, it fails in the same way. So, it seems like something has changed in nixpkgs such that this is occuring.

@colemickens
Copy link
Member Author

@colemickens colemickens commented Nov 24, 2019

It appears there's precedent with another package for using the 1.12 builder. I don't really understand it, but it unblocks upgrading the build. Should be good to go.
(ref:

# Version 1.2.0 fails to build with go 1.13 due to:
)

@colemickens colemickens force-pushed the colemickens:nixpkgs-azcopy branch from 44afd4a to cff97b9 Nov 24, 2019
@colemickens colemickens changed the title HELP NEEDED: azcopy: v10.0.1 -> v10.3.2 azcopy: 10.0.1 -> 10.3.2 Nov 24, 2019
Copy link
Contributor

@marsam marsam left a comment

Sorry for the delay. I've added a few suggestions, besides that LGTM

pkgs/development/tools/azcopy/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/azcopy/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@colemickens colemickens force-pushed the colemickens:nixpkgs-azcopy branch from cff97b9 to cb96302 Dec 9, 2019
@colemickens
Copy link
Member Author

@colemickens colemickens commented Dec 9, 2019

Thanks @marsam for the great review! I've made those changes and have updated this branch/PR.

pkgs/development/tools/azcopy/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/azcopy/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/azcopy/default.nix Outdated Show resolved Hide resolved
@colemickens colemickens force-pushed the colemickens:nixpkgs-azcopy branch from cb96302 to ab5fa1c Dec 9, 2019
@colemickens
Copy link
Member Author

@colemickens colemickens commented Dec 9, 2019

Thanks, hopefully this looks a bit better.

@marsam marsam force-pushed the colemickens:nixpkgs-azcopy branch from ab5fa1c to 0709d4e Dec 9, 2019
@marsam
Copy link
Contributor

@marsam marsam commented Dec 9, 2019

Thanks! I've made minor changes, I hope you don't mind

@GrahamcOfBorg build azure-storage-azcopy

@marsam marsam merged commit 29d242a into NixOS:master Dec 9, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
azure-storage-azcopy on aarch64-linux Success
Details
azure-storage-azcopy on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@colemickens colemickens deleted the colemickens:nixpkgs-azcopy branch Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.