Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tasksh: enable on Darwin #73691

Merged
merged 1 commit into from Nov 20, 2019
Merged

tasksh: enable on Darwin #73691

merged 1 commit into from Nov 20, 2019

Conversation

@eraserhd
Copy link
Contributor

eraserhd commented Nov 18, 2019

This works fine for me, which is unsurprising.

Motivation for this change

Enable use of this on Darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @matthiasbeyer

@ofborg ofborg bot added the 6.topic: darwin label Nov 18, 2019
@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Nov 18, 2019

@GrahamcOfBorg build tasksh

@alyssais

This comment has been minimized.

Copy link
Member

alyssais commented Nov 18, 2019

Is there any reason it shouldn’t be platforms.unix? Or even platforms.all?

@eraserhd eraserhd force-pushed the eraserhd:dogfood branch from 5fc5182 to 7f3b037 Nov 20, 2019
@eraserhd

This comment has been minimized.

Copy link
Contributor Author

eraserhd commented Nov 20, 2019

Changed to "platforms.unix", based on contents of INSTALL and CMakeLists.txt.

@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Nov 20, 2019

@GrahamcOfBorg build tasksh

@Mic92 Mic92 merged commit ce75a06 into NixOS:master Nov 20, 2019
15 of 16 checks passed
15 of 16 checks passed
tasksh on x86_64-darwin
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tasksh on aarch64-linux Success
Details
tasksh on x86_64-linux Success
Details
@eraserhd eraserhd deleted the eraserhd:dogfood branch Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.