Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fwupd: 1.2.10 → 1.3.3 #73700

Merged
merged 1 commit into from Nov 20, 2019
Merged

fwupd: 1.2.10 → 1.3.3 #73700

merged 1 commit into from Nov 20, 2019

Conversation

@jtojnar
Copy link
Contributor

jtojnar commented Nov 18, 2019

https://github.com/fwupd/fwupd/blob/1.3.2/data/org.freedesktop.fwupd.metainfo.xml#L35-L90

  • systemd.tmpfiles should not be necessary, as the systemd service switched to StateDirectory.

  • built on NixOS with sandboxing
  • ran the installed tests
  • Run fwupdmgr get-devices in the VM and checked there are no errors in the journal.

Closes: #71140

@jtojnar

This comment has been minimized.

Copy link
Contributor Author

jtojnar commented Nov 18, 2019

1.3.3 does not seem to build:

Traceback (most recent call last):
  File "/nix/store/4gnmpf8fyw636czvqkqx10bdmxkj124l-meson-0.51.2/lib/python3.7/site-packages/mesonbuild/mesonmain.py", line 127, in run
    return options.run_func(options)
  File "/nix/store/4gnmpf8fyw636czvqkqx10bdmxkj124l-meson-0.51.2/lib/python3.7/site-packages/mesonbuild/minstall.py", line 514, in run
    installer.do_install(datafilename)
  File "/nix/store/4gnmpf8fyw636czvqkqx10bdmxkj124l-meson-0.51.2/lib/python3.7/site-packages/mesonbuild/minstall.py", line 343, in do_install
    self.install_targets(d)
  File "/nix/store/4gnmpf8fyw636czvqkqx10bdmxkj124l-meson-0.51.2/lib/python3.7/site-packages/mesonbuild/minstall.py", line 436, in install_targets
    raise RuntimeError('File {!r} could not be found'.format(t.fname))
RuntimeError: File 'plugins/uefi/efi/fwupdx64.efi' could not be found
FAILED: meson-install
/nix/store/4gnmpf8fyw636czvqkqx10bdmxkj124l-meson-0.51.2/bin/meson install --no-rebuild

Most likely because of this:

[1/2] Generating fwupdx64.efi with a custom command.
/build/fwupd-1.3.3/plugins/uefi/efi/generate_binary.sh: line 3: which: not found
/build/fwupd-1.3.3/plugins/uefi/efi/generate_binary.sh: line 4: which: not found
/build/fwupd-1.3.3/plugins/uefi/efi/generate_binary.sh: line 6: -j: not found
https://github.com/fwupd/fwupd/blob/1.3.3/data/org.freedesktop.fwupd.metainfo.xml#L35-L125

systemd.tmpfiles should not be necessary, as the systemd service switched to StateDirectory.
@jtojnar jtojnar force-pushed the jtojnar:fwupd-1.3 branch from c9d1310 to 5b8998f Nov 18, 2019
@jtojnar jtojnar changed the title fwupd: 1.2.10 → 1.3.2 fwupd: 1.2.10 → 1.3.3 Nov 18, 2019
@jtojnar

This comment has been minimized.

Copy link
Contributor Author

jtojnar commented Nov 18, 2019

Do not have genpeimg to mark ASLR and DP/NX on EFI binary but it builds without it.

@jtojnar

This comment has been minimized.

Copy link
Contributor Author

jtojnar commented Nov 18, 2019

fwupdmgr seems to work fine in the VM, no warnings in the journal.

@worldofpeace worldofpeace requested a review from dtzWill Nov 20, 2019
@jtojnar jtojnar merged commit 91b02cd into NixOS:master Nov 20, 2019
16 checks passed
16 checks passed
fwupd on aarch64-linux Timed out, unknown build status
Details
fwupd on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
fwupd on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jtojnar jtojnar deleted the jtojnar:fwupd-1.3 branch Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.