Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocaml-sodium: init at 0.6.0 #73713

Merged
merged 1 commit into from Nov 22, 2019
Merged

ocaml-sodium: init at 0.6.0 #73713

merged 1 commit into from Nov 22, 2019

Conversation

@rixed
Copy link
Contributor

@rixed rixed commented Nov 18, 2019

Motivation for this change

Trivial packaging of the libsodium bindings for OCaml, that I need for a less trivial one.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@vbgl
Copy link
Contributor

@vbgl vbgl commented Nov 20, 2019

@GrahamcOfBorg build ocamlPackages.sodium

@vbgl
Copy link
Contributor

@vbgl vbgl commented Nov 20, 2019

May you have a look at the build failure on darwin? It’s probably related to hardening, that you may disable on that platform (see: https://nixos.org/nixpkgs/manual/#sec-hardening-in-nixpkgs). Maybe something like:

hardeningDisable = stdenv.lib.optional stdenv.isDarwin "strictoverflow";
@rixed rixed force-pushed the rixed:ocaml-sodium branch from 2268803 to 12433ae Nov 21, 2019
@rixed
Copy link
Contributor Author

@rixed rixed commented Nov 21, 2019

Indeed I had an error on macos:

clang-7: error: argument unused during compilation: '-fno-strict-overflow'

And the suggested change fixes it.
Stupid question I know, but how did you know? I couldn't see on the PR page any mention of a failed build.

@vbgl
Copy link
Contributor

@vbgl vbgl commented Nov 22, 2019

@GrahamcOfBorg build ocamlPackages.sodium

@vbgl vbgl merged commit 359e644 into NixOS:master Nov 22, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
ocamlPackages.sodium on aarch64-linux Success
Details
ocamlPackages.sodium on x86_64-darwin Success
Details
ocamlPackages.sodium on x86_64-linux Success
Details
@vbgl
Copy link
Contributor

@vbgl vbgl commented Nov 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.