Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elasticsearch-curator: move out of python-packages #73717

Merged

Conversation

@jonringer
Copy link
Contributor

jonringer commented Nov 18, 2019

Motivation for this change

Upstream froze click to <7, which means it will only
work with overrides, which means it can't compose
with other python modules.

previously, this was just broken when trying to build as pythonXPackages.elasticsearch-curator, and only the application worked because it overrided the version of click

partially resolves #68587

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73717
1 package were build:
elasticsearch-curator
Upstream froze click to <7, which means it will only
work with overrides, which means it can't compose
with other python modules.
@jonringer jonringer requested a review from FRidh as a code owner Nov 18, 2019
@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Nov 18, 2019

@GrahamcOfBorg test elk

@FRidh
FRidh approved these changes Nov 19, 2019
@jonringer jonringer merged commit 6a983b6 into NixOS:master Nov 19, 2019
18 checks passed
18 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
elasticsearch-curator on aarch64-linux Success
Details
elasticsearch-curator on x86_64-darwin Success
Details
elasticsearch-curator on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.elk on aarch64-linux Success
Details
tests.elk on x86_64-linux Success
Details
@jonringer jonringer deleted the jonringer:move-elastic-curator-out-of-python-modules branch Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.