Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
endless-sky: 0.9.8 -> 0.9.10 #73719
Motivation for this change
New upstream release
I ran that command inside my working git repo with the updated package definition. It said it “No diff detected”. I'm really not sure how that review tool is supposed to be run. Is that what I'm supposed to do, or is it something completely different? At any rate, I don't think any other package depends on endless-sky, but I'm not really sure how to verify that.
@lheckemann, thanks for merging! But since I'll likely send more PRs to nixpkgs, would you mind clarifying for me the
First off: none of the bullet points are hard requirements, except being fine with the licencing as outlined in CONTRIBUTING.md.
As for nix-review, I'm not entirely sure. I think it's for testing unstaged changes in your git checkout, which is of course quite an individual workflow preference. In addition, since endless-sky is a leaf package (nothing depends on it), there's not much point in using it beyond checking if ES itself builds.