Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

endless-sky: 0.9.8 -> 0.9.10 #73719

Merged
merged 1 commit into from Nov 19, 2019
Merged

endless-sky: 0.9.8 -> 0.9.10 #73719

merged 1 commit into from Nov 19, 2019

Conversation

@willghatch
Copy link
Contributor

willghatch commented Nov 18, 2019

Motivation for this change

New upstream release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [?] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"

I ran that command inside my working git repo with the updated package definition. It said it “No diff detected”. I'm really not sure how that review tool is supposed to be run. Is that what I'm supposed to do, or is it something completely different? At any rate, I don't think any other package depends on endless-sky, but I'm not really sure how to verify that.

  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @lheckemann

@lheckemann

This comment has been minimized.

Copy link
Member

lheckemann commented Nov 19, 2019

@GrahamcOfBorg build endless-sky

@lheckemann

This comment has been minimized.

Copy link
Member

lheckemann commented Nov 19, 2019

Thanks, completely missed this release since there was no blog post about it!

@lheckemann lheckemann merged commit ff1ead8 into NixOS:master Nov 19, 2019
16 checks passed
16 checks passed
endless-sky on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
endless-sky on aarch64-linux Success
Details
endless-sky on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@willghatch

This comment has been minimized.

Copy link
Contributor Author

willghatch commented Nov 19, 2019

@lheckemann, thanks for merging! But since I'll likely send more PRs to nixpkgs, would you mind clarifying for me the nix-review bullet point? Are you supposed to just run that command inside your working git clone of nixpkgs, or are you supposed to do something else? Or is there somewhere other than the PR template that explains it?

@lheckemann

This comment has been minimized.

Copy link
Member

lheckemann commented Nov 21, 2019

First off: none of the bullet points are hard requirements, except being fine with the licencing as outlined in CONTRIBUTING.md.

As for nix-review, I'm not entirely sure. I think it's for testing unstaged changes in your git checkout, which is of course quite an individual workflow preference. In addition, since endless-sky is a leaf package (nothing depends on it), there's not much point in using it beyond checking if ES itself builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.