Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dante: fix package under Linux #73746

Merged
merged 1 commit into from Jan 12, 2020
Merged

dante: fix package under Linux #73746

merged 1 commit into from Jan 12, 2020

Conversation

@Shados
Copy link
Contributor

Shados commented Nov 19, 2019

Motivation for this change

Fixes #73697 and this issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@nloomans

This comment has been minimized.

Copy link
Contributor

nloomans commented Dec 15, 2019

Anything keeping this from being merged? Building aerc from this branch fixes the socksify: error: dante client not built with preloading support. error I'm getting when opening text/html email.

Copy link
Contributor

nloomans left a comment

I reviewed this package following the https://discourse.nixos.org/t/prs-already-reviewed/2617/1 guide.

nixpkgs-review pr 73746 returned no errors and text/html emails work.

[x] reviewed the diff and commit messages
[x] made sure ofBorg build succeeded for all applicable platforms
[x] run nix-review for a reasonable amount of time without any failures (or marked preexisting failures as broken)

@nixos-discourse

This comment has been minimized.

Copy link

nixos-discourse commented Jan 12, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/83

@markuskowa

This comment has been minimized.

Copy link
Member

markuskowa commented Jan 12, 2020

@GrahamcOfBorg build dante

Copy link
Member

markuskowa left a comment

Sorry misread the problem

@markuskowa markuskowa merged commit 26a4e0e into NixOS:master Jan 12, 2020
15 of 16 checks passed
15 of 16 checks passed
dante on aarch64-linux
Details
Evaluation Performance Report Evaluator Performance Report
Details
dante on x86_64-darwin Success
Details
dante on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.