Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/prometheus: 'configText' -> 'configFile' and final config in /etc #73751

wants to merge 1 commit into
base: master


Copy link

johanot commented Nov 19, 2019

Motivation for this change

This allows for configuration of a custom path to the main Prometheus config file. At the same time configText becomes obsolete, as configFile is easily combined with pkgs.writeText for users of the module.

Most importantly though, this PR symlinks /etc/prometheus/prometheus.yaml to the promtool checked configuration. Which, is desirable for optional user application of reloadIfChanged = true on the Prometheus systemd service. By referencing a store path only, it is currently not possible to SIGHUP Prometheus when the configuration changes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits
Notify maintainers

cc @WilliButz @globin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
1 participant
You can’t perform that action at this time.