Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openxray: make it work again #73753

Merged
merged 1 commit into from Nov 24, 2019
Merged

openxray: make it work again #73753

merged 1 commit into from Nov 24, 2019

Conversation

@gnidorah
Copy link
Member

gnidorah commented Nov 19, 2019

Motivation for this change

Needed after #72199
See OpenXRay/xray-16#518

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@FRidh

This comment has been minimized.

Copy link
Member

FRidh commented Nov 19, 2019

Please add the meta information.

@gnidorah

This comment has been minimized.

Copy link
Member Author

gnidorah commented Nov 19, 2019

@FRidh to local cryptopp? Is that required? openxray is unfree and not built on hydra

@FRidh

This comment has been minimized.

Copy link
Member

FRidh commented Nov 19, 2019

indeed for cryptopp. Derivations should have meta information.

@gnidorah gnidorah force-pushed the gnidorah:openxray branch from 3008e23 to 6a0b9d7 Nov 19, 2019
@gnidorah gnidorah force-pushed the gnidorah:openxray branch from 6a0b9d7 to de233a8 Nov 19, 2019
@gnidorah

This comment has been minimized.

Copy link
Member Author

gnidorah commented Nov 19, 2019

@FRidh Done

Copy link
Contributor

Lassulus left a comment

tested with nix-review, seems to work

@Lassulus Lassulus merged commit c67d3f1 into NixOS:master Nov 24, 2019
15 checks passed
15 checks passed
openxray on aarch64-linux No attempt
Details
openxray on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@gnidorah

This comment has been minimized.

Copy link
Member Author

gnidorah commented Nov 24, 2019

@FRidh @Lassulus thanks!

@gnidorah gnidorah deleted the gnidorah:openxray branch Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.