Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tests/installer: support useEFIBoot (depends on #73237) #73768

Open
wants to merge 2 commits into
base: master
from

Conversation

@betaboon
Copy link
Contributor

betaboon commented Nov 19, 2019

Motivation for this change

As discussed here in #58121 some work was required to allow booting to EFI when starting the VM which is used to run nixos-install.
This is in effect required for cases where we want to install an EFI-bootmanager into non-fallback-locations(as opposed to /EFI/BOOT/...).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @samueldr

@betaboon betaboon force-pushed the betaboon:tests-installer-efi-boot branch from 324fe70 to bdd37ee Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.