Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skypeforlinux: Adding archive.org mirror #73771

Merged
merged 1 commit into from Nov 19, 2019

Conversation

@d-goldin
Copy link
Contributor

d-goldin commented Nov 19, 2019

Motivation for this change

Addresses: #73597

Adding an additional web-archive url to avoid breakage when
old versions disappear from upstream. Still keeping original location
to not needlessly hit archive.org (it's also slower).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @PanAeon @jraygauthier

@jamescostian

Adding an additional web-archive url to avoid breakage when
old versions disappear from upstream. Still keeping original location
to not needlessly hit archive.org (it's also slower).
urls = [
"https://repo.skype.com/deb/pool/main/s/skypeforlinux/skypeforlinux_${version}_amd64.deb"
"https://web.archive.org/web/https://repo.skype.com/deb/pool/main/s/skypeforlinux/skypeforlinux_${version}_amd64.deb"
];

This comment has been minimized.

Copy link
@grahamc

grahamc Nov 19, 2019

Member

I have no trouble with this PR. I wonder how Archive.org feels about following the license of Skype, which I assume says you can't redistribute it :)

This comment has been minimized.

Copy link
@d-goldin

d-goldin Nov 19, 2019

Author Contributor

There is some precedent for using this approach in #70155 and a few other places for unreliable upstreams. But yes, indeed the big question remains, what does this actually mean in legal terms for archive.org. Maybe @fpletz knows sth.

In general, longer term, I'd almost prefer if we would move out a lot of those nastier non-free things in some way that still allows the users to use nix to install it, but versions and urls and what not would not sth that we manage in the core repo (like NUR/flakes). Because otherwise either we keep chasing versions or deal with what we see here.

This comment has been minimized.

Copy link
@d-goldin

d-goldin Nov 19, 2019

Author Contributor

From ToS (https://www.skype.com/en/legal/ios/tos/ relevant section 4):

For the avoidance of doubt, (a) IT administrators working on behalf of a company may download and install the Skype Software onto personal computers or other devices used by personnel of such company; and (b) you are permitted to use the Software at a university or other educational institution, or at work. Skype reserves all rights not expressly granted to you under these Terms.

Applying not-lawyer-reasoning, apt-mirrors would be at least fine until those terms.

@d-goldin

This comment has been minimized.

Copy link
Contributor Author

d-goldin commented Nov 19, 2019

Once this has been clarified / cleared, I will provide a backport for r19.09.

@grahamc

This comment has been minimized.

Copy link
Member

grahamc commented Nov 19, 2019

I have no concern around merging this and backporting it, I don't think we need to worry about Archive.org's concerns :)

@grahamc grahamc merged commit cccabc7 into NixOS:master Nov 19, 2019
15 checks passed
15 checks passed
skypeforlinux on aarch64-linux No attempt
Details
skypeforlinux on x86_64-darwin No attempt
Details
skypeforlinux on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@d-goldin d-goldin deleted the d-goldin:skype_archiveorg_mirror branch Nov 19, 2019
@d-goldin d-goldin mentioned this pull request Nov 19, 2019
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.