Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brotab: init at 0.0.5 #73777

Open
wants to merge 2 commits into
base: master
from
Open

brotab: init at 0.0.5 #73777

wants to merge 2 commits into from

Conversation

@doronbehar
Copy link
Contributor

doronbehar commented Nov 19, 2019

Motivation for this change

Browser tab controller - https://github.com/balta2ar/brotab

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

pkgs/tools/misc/brotab/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/brotab/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/brotab/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/brotab/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/brotab/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@doronbehar doronbehar force-pushed the doronbehar:package-brotab branch from 220f380 to 4ff5b50 Nov 19, 2019
@doronbehar

This comment has been minimized.

Copy link
Contributor Author

doronbehar commented Nov 19, 2019

Thanks for the comments @jonringer !

Copy link
Contributor

jonringer left a comment

this repo seems to be most a 1 person show with no other repositories currently packaging this.

Why should ilt be added to nixpkgs?

pkgs/tools/misc/brotab/default.nix Show resolved Hide resolved
@doronbehar

This comment has been minimized.

Copy link
Contributor Author

doronbehar commented Nov 20, 2019

Why should ilt be added to nixpkgs?

Well first of all, the fact it's not famous enough so that other repos will include it doesn't mean the package is not useful. The least I can in order to support this software is to distribute it, starting with NixOS.

Besides that, it's not just a script that one can git clone and link to his $PATH - the package consists of several executables the browser extension needs to be aware of. Hence it's almost impossible for NixOS users to use it without installing it the Nix way. EDIT: see balta2ar/brotab#7

@doronbehar

This comment has been minimized.

Copy link
Contributor Author

doronbehar commented Jan 8, 2020

What say you @jonringer ?

@doronbehar doronbehar force-pushed the doronbehar:package-brotab branch 2 times, most recently from 328289a to df17bf6 Jan 8, 2020
@doronbehar doronbehar force-pushed the doronbehar:package-brotab branch from df17bf6 to 052c103 Jan 8, 2020
Co-Authored-By: Jon <jonringer@users.noreply.github.com>
Copy link
Contributor

jonringer left a comment

diff LGTM
commits LGTM
has tests 👍

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73777
1 package built:
brotab
@jonringer

This comment has been minimized.

Copy link
Contributor

jonringer commented Jan 9, 2020

@GrahamcOfBorg build brotab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.