Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ldns: 1.7.0 -> 1.7.1 #73797

Merged
merged 2 commits into from Nov 20, 2019
Merged

ldns: 1.7.0 -> 1.7.1 #73797

merged 2 commits into from Nov 20, 2019

Conversation

@dtzWill
Copy link
Contributor

dtzWill commented Nov 20, 2019

Motivation for this change

https://www.nlnetlabs.nl/news/2019/Jul/26/ldns-1.7.1-released/

  • examples no longer can be configured separately,
    so build everything we want in a single go
    and sort into the appropriate outputs after.
  • libtool file doesn't seem to reference openssl at all
    so nothing to patch up there as we did previously.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
dtzWill added 2 commits Jul 27, 2019
https://www.nlnetlabs.nl/news/2019/Jul/26/ldns-1.7.1-released/

* examples no longer can be configured separately,
  so build everything we want in a single go
  and sort into the appropriate outputs after.
* libtool file doesn't seem to reference openssl at all
  so nothing to patch up there as we did previously.
@dtzWill

This comment has been minimized.

Copy link
Contributor Author

dtzWill commented Nov 20, 2019

(reviewers requested per github suggestion, FWIW and thank you :))

@vcunat

This comment has been minimized.

Copy link
Member

vcunat commented Nov 20, 2019

@GrahamcOfBorg build dnscrypt-proxy strongswan tlspool freeswitch

@vcunat
vcunat approved these changes Nov 20, 2019
vcunat added a commit that referenced this pull request Nov 20, 2019
@vcunat vcunat merged commit d9c19f4 into NixOS:master Nov 20, 2019
19 checks passed
19 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
dnscrypt-proxy, freeswitch, strongswan, tlspool on aarch64-linux Success
Details
dnscrypt-proxy, freeswitch, strongswan, tlspool on x86_64-darwin Success
Details
dnscrypt-proxy, freeswitch, strongswan, tlspool on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
ldns on aarch64-linux Success
Details
ldns on x86_64-darwin Success
Details
ldns on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.