Skip to content

nixos/timesyncd: add extraConfig option #73802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Nov 20, 2019

This adds an extraConfig option to timesyncd for setting additional
options in /etc/systemd/timesyncd.conf.

This is similar to things like services.journald.extraConfig and
services.logind.extraConfig.

To test this, in my local configuration.nix I added the following:

{
  services.timesyncd.extraConfig = ''
    PollIntervalMaxSec=180
  '';
}

After running nixos-rebuild switch, here is the content of the /etc/systemd/timesyncd.conf file:

[Time]
NTP=0.nixos.pool.ntp.org 1.nixos.pool.ntp.org 2.nixos.pool.ntp.org 3.nixos.pool.ntp.org
PollIntervalMaxSec=180

Here's the output of the two relevant timedatectl commands:

$ timedatectl timesync-status
       Server: 198.13.37.28 (0.nixos.pool.ntp.org)
Poll interval: 4min 16s (min: 32s; max 3min)
         Leap: normal
      Version: 4
...
$ timedatectl show-timesync 
SystemNTPServers=0.nixos.pool.ntp.org 1.nixos.pool.ntp.org 2.nixos.pool.ntp.org 3.nixos.pool.ntp.org
FallbackNTPServers=0.nixos.pool.ntp.org 1.nixos.pool.ntp.org 2.nixos.pool.ntp.org 3.nixos.pool.ntp.org
ServerName=0.nixos.pool.ntp.org
ServerAddress=198.13.37.28
RootDistanceMaxUSec=5s
PollIntervalMinUSec=32s
PollIntervalMaxUSec=3min
PollIntervalUSec=4min 16s
...

You can see that the max poll interval has been updated.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

Pinging some of the people I recognize in the git history for the timesyncd module: @flokli @andir

This adds an `extraConfig` option to timesyncd for setting additional
options in `/etc/systemd/timesyncd.conf`.

This is similar to things like `services.journald.extraConfig` and
`services.logind.extraConfig`.
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 20, 2019
@andir andir merged commit 58fb23f into NixOS:master Nov 20, 2019
@cdepillabout cdepillabout deleted the add-extraconfig-to-timesyncd branch November 20, 2019 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants