Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maintainer-list.nix #73807

Closed
wants to merge 1 commit into from
Closed

Update maintainer-list.nix #73807

wants to merge 1 commit into from

Conversation

@thefenriswolf
Copy link
Contributor

thefenriswolf commented Nov 20, 2019

add thefenriswolf, maintainer of tensorman

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

add thefenriswolf, maintainer of tensorman
@prusnak

This comment has been minimized.

Copy link
Member

prusnak commented Nov 20, 2019

Maybe just merge this commit (as a separate commit!) into #73452 and close this PR.

@thefenriswolf

This comment has been minimized.

Copy link
Contributor Author

thefenriswolf commented Nov 20, 2019

Maybe just merge this commit (as a separate commit!) into #73452 and close this PR.

I don't get what I am supposed to do! Should this be a separate PR or not?
Please just ELI5 I'm lost

@prusnak

This comment has been minimized.

Copy link
Member

prusnak commented Nov 20, 2019

Not a separate PR, but put a separate commit into #73452 (so this PR will contain two commits: one new package, one new maintainer)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.