Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kops_1_15: init at 1.15.0 #73809

Merged
merged 1 commit into from Dec 3, 2019
Merged

kops_1_15: init at 1.15.0 #73809

merged 1 commit into from Dec 3, 2019

Conversation

@kampka
Copy link
Contributor

kampka commented Nov 20, 2019

Motivation for this change

New package version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @zimbatm

@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Nov 20, 2019

What is the policy for keeping old versions for this package?

@kampka

This comment has been minimized.

Copy link
Contributor Author

kampka commented Nov 20, 2019

What is the policy for keeping old versions for this package?

I don't think there is one yet.
Typically the idea is to not force people to upgrade production clusters whenever nixpkgs updates.
I think it's reasonable to adopt the k8s supported versions model here, which boils down to the lastest three minor versions.

That being said, I would keep the existing versions because 1.12 introduces a breaking change and upgrading from <1.12 to >1.12 is not really supported.

@kampka

This comment has been minimized.

Copy link
Contributor Author

kampka commented Nov 26, 2019

Weekly reminder that this still needs a review.

@kampka

This comment has been minimized.

Copy link
Contributor Author

kampka commented Dec 3, 2019

@Mic92 So how do we make progress here?
This seems like a simple version bump to me, I don't really get why this has to linger here for weeks.

@zimbatm @offlinehacker @ehmry

@zimbatm zimbatm merged commit a951af1 into NixOS:master Dec 3, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
kops_1_15 on aarch64-linux Success
Details
kops_1_15 on x86_64-linux Success
Details
@zimbatm

This comment has been minimized.

Copy link
Member

zimbatm commented Dec 3, 2019

let's cleanup the old versions later. Usually we keep the 3 latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.