Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virt-manager: use setupPyGlobalFlags #73813

Merged
merged 3 commits into from Nov 28, 2019
Merged

virt-manager: use setupPyGlobalFlags #73813

merged 3 commits into from Nov 28, 2019

Conversation

@aske
Copy link
Member

aske commented Nov 20, 2019

Motivation for this change

Now that we have setupPyDistFlags we can remove the custom buildPhase.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@aske

This comment has been minimized.

Copy link
Member Author

aske commented Nov 20, 2019

Not really related to this PR, but @FRidh do you still want to rename setupPyBuildFlags, etc.? (+1 to these names.)

@aske aske force-pushed the aske:virt-man-flags branch from 34486b3 to 46f34ef Nov 20, 2019
@aske aske changed the title virt-manager: use setupPyDistFlags virt-manager: use setupPyGlobalFlags Nov 20, 2019
@aske aske force-pushed the aske:virt-man-flags branch from 46f34ef to 3d7d72b Nov 20, 2019
@ofborg ofborg bot requested review from qknight, offlinehacker, globin and fpletz Nov 20, 2019
@teto
teto approved these changes Nov 21, 2019
aske added 2 commits Nov 21, 2019
buildPythonApplication does namePrefix = ""
@aske

This comment has been minimized.

Copy link
Member Author

aske commented Nov 28, 2019

Can anyone merge this?

@FRidh FRidh merged commit 072f9fe into NixOS:master Nov 28, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
virt-manager on aarch64-linux Success
Details
virt-manager on x86_64-linux Success
Details
@aske

This comment has been minimized.

Copy link
Member Author

aske commented Nov 28, 2019

@FRidh thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.