Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zenpower: init at 0.1.5 #73814

Merged
merged 1 commit into from Jan 16, 2020
Merged

zenpower: init at 0.1.5 #73814

merged 1 commit into from Jan 16, 2020

Conversation

@alexbakker
Copy link
Member

alexbakker commented Nov 20, 2019

Motivation for this change

Linux kernel driver for reading temperature, voltage(SVI2), current(SVI2) and power(SVI2) for AMD Zen family CPUs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

jonringer left a comment

I got a few failures, not sure if you want to mark it broken for the incompatible kernel+hardening combinations:

[12 built (2 failed), 26 copied (2111.5 MiB), 956.3 MiB DL]
error: build of '/nix/store/zldz13zp5pwjdz00a17a7bnj5c3ihfra-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/73814
2 package are marked as broken and were skipped:
linuxPackages_hardkernel_4_14.zenpower linuxPackages_hardkernel_latest.zenpower

2 package failed to build:
linuxPackages_4_4.zenpower linuxPackages_4_9.zenpower

11 package were built:
linuxPackages-libre.zenpower linuxPackages.zenpower linuxPackages_4_14.zenpower linuxPackages_5_3.zenpower linuxPackages_hardened.zenpower linuxPackages_latest-libre.zenpower linuxPackages_latest_hardened.zenpower linuxPackages_latest_xen_dom0.zenpower linuxPackages_testing_bcachefs.zenpower linuxPackages_testing_hardened.zenpower linuxPackages_xen_dom0.zenpower
@alexbakker alexbakker force-pushed the alexbakker:zenpower branch from b1eb714 to 884d77e Nov 27, 2019
@alexbakker

This comment has been minimized.

Copy link
Member Author

alexbakker commented Nov 27, 2019

@jonringer Thanks. I've marked kernel versions below 4.14 as broken.

pkgs/os-specific/linux/zenpower/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/zenpower/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/zenpower/default.nix Outdated Show resolved Hide resolved
@alexbakker alexbakker force-pushed the alexbakker:zenpower branch from 884d77e to 93c5503 Nov 27, 2019
@alexbakker

This comment has been minimized.

Copy link
Member Author

alexbakker commented Nov 27, 2019

@jonringer Fixed.

@alexbakker

This comment has been minimized.

Copy link
Member Author

alexbakker commented Jan 2, 2020

What's the status here? Can this be merged?

Copy link
Contributor

filalex77 left a comment

diff LGTM
checked with nixpkgs-review

[13 built, 60 copied (1922.2 MiB), 866.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73814
5 package marked as broken and skipped:
linuxPackages_4_4.zenpower linuxPackages_4_9.zenpower linuxPackages_5_3.zenpower linuxPackages_hardkernel_4_14.zenpower linuxPackages_hardkernel_latest.zenpower

11 package built:
linuxPackages-libre.zenpower linuxPackages.zenpower linuxPackages_4_14.zenpower linuxPackages_5_4.zenpower linuxPackages_hardened.zenpower linuxPackages_latest-libre.zenpower linuxPackages_latest_hardened.zenpower linuxPackages_latest_xen_dom0.zenpower linuxPackages_testing_bcachefs.zenpower linuxPackages_testing_hardened.zenpower linuxPackages_xen_dom0.zenpower

cc @marsam for (possibly) merging. Thanks!

@marsam marsam merged commit 4186705 into NixOS:master Jan 16, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@marsam

This comment has been minimized.

Copy link
Contributor

marsam commented Jan 16, 2020

Thank you, sorry for the delay.
@alexbakker please ping me if any PR gets stuck

@alexbakker

This comment has been minimized.

Copy link
Member Author

alexbakker commented Jan 16, 2020

@marsam No worries! And thanks, I'll keep that in mind!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.