Skip to content

clj-kondo: 2019.11.03 -> 2019.11.07 #73818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2019
Merged

clj-kondo: 2019.11.03 -> 2019.11.07 #73818

merged 1 commit into from
Nov 22, 2019

Conversation

jlesquembre
Copy link
Member

Motivation for this change

Update clj-kondo

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from bennyandresen November 20, 2019 14:01
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 20, 2019
bennyandresen
bennyandresen approved these changes Nov 21, 2019
View reviewed changes
Copy link
Member

@bennyandresen bennyandresen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cc: @FRidh, @worldofpeace (I hope this is okay due to busy state)

@worldofpeace worldofpeace merged commit 2eeb0d3 into NixOS:master Nov 22, 2019
@worldofpeace
Copy link
Contributor

LGTM!

cc: @FRidh, @worldofpeace (I hope this is okay due to busy state)

Yep, merging is pretty normal for me even when I'm busy 👍

@jlesquembre jlesquembre deleted the clj-kondo branch May 5, 2020 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennyandresen bennyandresen bennyandresen approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlesquembre @worldofpeace @bennyandresen