New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multithreaded perl on darwin #73819
Multithreaded perl on darwin #73819
Conversation
This is the output of
|
305b177
to
768afea
Compare
768afea
to
ad62940
Compare
This had become an stdenv rebuild on linux, which not supposed to be an effect here. @knl I think you should investigate or revert to a previous version. |
@knl @veprbl apparently
So So this is to be expected and I think it's OK to merge. |
Perl on darwin (and any other sane platform) has a pretty good threading support, enable it. As it turns out, we were building non-multithreaded perl on all systems, since glibc was not part of the stdenv anymore: nix-repl> pkgs = import <nixpkgs> {} nix-repl> pkgs.stdenv ? glibc false meaning that the comments were incorrect. Thus, clear up the confusion and remove the misleading comments, while enabling multithreading by default. The builds will fail on unsupported platforms, and in this case the only place is the bootstrap, where we already force non-multithreaded perl. As a consequence of the above, this change will cause the full rebuild of stdenv on all platforms, including linux.
ad62940
to
b5b49ed
Compare
@GrahamcOfBorg build perl |
Motivation for this change
note: the below text was set in place after all the fruitful discussion happening in this PR. Initially, it only said about enabling multithreaded perl on Darwin, which was not correct.
Perl on darwin (and any other sane platform) has a pretty good threading
support, enable it.
As it turns out, we were building non-multithreaded perl on all systems,
since glibc was not part of the stdenv anymore:
meaning that the comments were incorrect. Thus, clear up the confusion
and remove the misleading comments, while enabling multithreading by
default. The builds will fail on unsupported platforms, and in this case
the only place is the bootstrap, where we already force
non-multithreaded perl.
As a consequence of the above, this change will cause the full rebuild
of stdenv on all platforms, including linux.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @eelco @matthewbauer