Skip to content

/ nixpkgs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.LanguageClient-neovim: 0.1.154 -> 0.1.155 #73832

Merged
merged 1 commit into from Dec 10, 2019
Merged

vimPlugins.LanguageClient-neovim: 0.1.154 -> 0.1.155 #73832

merged 1 commit into from Dec 10, 2019

Conversation

@minijackson
Copy link
Contributor

minijackson commented Nov 20, 2019

Motivation for this change

New version! \o/

https://github.com/autozimu/LanguageClient-neovim/releases/tag/0.1.155

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

No maintainer? 😢
@minijackson
vimPlugins.LanguageClient-neovim: 0.1.154 -> 0.1.155
Verified
This commit was signed with a verified signature.
minijackson Rémi NICOLE
GPG key ID: FEA888C9F5D64F62 Learn about signing commits
Loading status checks…
ce5c2ce
@minijackson minijackson requested a review from jonringer as a code owner Nov 20, 2019
@teto

This comment has been minimized.

Sign in to view
Copy link
Contributor

teto commented Nov 21, 2019

wanna add yourself as a maintainer (note that neovim's master has its own LSP embedded now)
@minijackson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

minijackson commented Nov 21, 2019

With neovim adding its own LSP support, I don't know if I'm going to keep on using LanguageClient (maybe, maybe not), so I don't want to get ahead of myself
@teto

This comment has been minimized.

Sign in to view
Copy link
Contributor

teto commented Nov 21, 2019

@GrahamcOfBorg build vimPlugins.LanguageClient-neovim
1 similar comment
@teto

This comment has been minimized.

Sign in to view
Copy link
Contributor

teto commented Nov 22, 2019

@GrahamcOfBorg build vimPlugins.LanguageClient-neovim
@minijackson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

minijackson commented Dec 10, 2019

Up?
@teto teto merged commit 8797d4f into NixOS:master Dec 10, 2019
16 checks passed
16 checks passed
vimPlugins.LanguageClient-neovim on x86_64-darwin Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
vimPlugins.LanguageClient-neovim on aarch64-linux Success
Details
vimPlugins.LanguageClient-neovim on x86_64-linux Success
Details
@teto

This comment has been minimized.

Sign in to view
Copy link
Contributor

teto commented Dec 10, 2019

btw, I've been using neovim's native lsp and it really is great. On par with coc I would say (though less documented and still a moving target).
@minijackson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

minijackson commented Dec 10, 2019

awesome, can't wait until it is released!
@minijackson minijackson deleted the minijackson:LanguageClient-neovim-0.1.155 branch Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 6.topic: vim
Projects
None yet
Milestone
No milestone
2 participants
@minijackson @teto
You can’t perform that action at this time.