Skip to content

python3Packages.tensorboard: add wheel as runtime dep #73842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2019
Merged

python3Packages.tensorboard: add wheel as runtime dep #73842

merged 1 commit into from
Nov 21, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 20, 2019 •
edited
Loading

Motivation for this change

resolves #73840

Added some tests to ensure that the build breaks if the cli is broken.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Nov 20, 2019
@ofborg ofborg bot requested a review from abbradar November 20, 2019 23:29
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Nov 20, 2019
@jonringer
python3Packages.tensorflow-tensorboard: add wheel as runtime dep
b5b139d 
The cli requires the wheel package to determine
entry points for execution.
@jonringer
Copy link
Contributor Author

needed to correct commit message

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python3Packages.tensorflow-tensorboard pythonPackages.tensorflow-tensorboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh approved these changes

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
6.topic: python Python is a high-level, general-purpose programming language. 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tensorboard failing to start in unstable
2 participants
@jonringer @FRidh