Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.tensorboard: add wheel as runtime dep #73842

Merged
merged 1 commit into from Nov 21, 2019

Conversation

@jonringer
Copy link
Contributor

jonringer commented Nov 20, 2019

Motivation for this change

resolves #73840

Added some tests to ensure that the build breaks if the cli is broken.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

The cli requires the wheel package to determine
entry points for execution.
@jonringer jonringer force-pushed the jonringer:fix-tensorboard branch from c74196c to b5b139d Nov 21, 2019
@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Nov 21, 2019

needed to correct commit message

@jonringer

This comment has been minimized.

Copy link
Contributor Author

jonringer commented Nov 21, 2019

@GrahamcOfBorg build python3Packages.tensorflow-tensorboard pythonPackages.tensorflow-tensorboard

@FRidh
FRidh approved these changes Nov 21, 2019
@jonringer jonringer merged commit 7d091ce into NixOS:master Nov 21, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python3Packages.tensorflow-tensorboard, pythonPackages.tensorflow-tensorboard on aarch64-linux Success
Details
python3Packages.tensorflow-tensorboard, pythonPackages.tensorflow-tensorboard on x86_64-darwin Success
Details
python3Packages.tensorflow-tensorboard, pythonPackages.tensorflow-tensorboard on x86_64-linux Success
Details
@jonringer jonringer deleted the jonringer:fix-tensorboard branch Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.