Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neovim-qt: 0.2.12 -> 0.2.15 #73854

Merged
merged 1 commit into from Jan 13, 2020
Merged

neovim-qt: 0.2.12 -> 0.2.15 #73854

merged 1 commit into from Jan 13, 2020

Conversation

@Dema
Copy link
Contributor

@Dema Dema commented Nov 21, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

nix-review failed with the following error, but I was able to compile it and run sucessfully on my machine

builder for '/nix/store/2327mmims9ypfc5vlzrz6jc0yzy302nw-luajit-2.1.0-beta3-env.drv' failed with exit code 1; last 2 log lines:
  created 16 symlinks in user environment
  /nix/store/wpi89y86krq9rbvwcbx0hc36ibp5d0v7-stdenv-linux/setup: line 320: [@]: bad substitution
cannot build derivation '/nix/store/i9l40vp8mw2vb7w1qi4ba8j808nsz18p-neovim-unwrapped-0.4.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/nyf3avymprn7wm0can324s2nfdxs6yvc-neovim-0.4.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/kl0xsxpmbsdjkdah8il9vag494s9b5cw-neovim-qt-unwrapped-0.2.15.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/034v125nihgnv1282jmdydan1x20gn0f-neovim-qt-0.2.15.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/yvcd9rwf77pdzlcqagaqa4z8a0f875p2-env.drv': 1 dependencies couldn't be built
[0 built (1 failed)]
error: build of '/nix/store/yvcd9rwf77pdzlcqagaqa4z8a0f875p2-env.drv' failed
1 package failed to build:
neovim-qt

[0.0 MiB DL]
error: build log of '/nix/store/034v125nihgnv1282jmdydan1x20gn0f-neovim-qt-0.2.15.drv' is not available
$ nix-shell /home/dema/.cache/nix-review/rev-e40adc8788c506ff24a4dec5cf83b8c26dadecfc-1/shell.nix```
@Dema
Copy link
Contributor Author

@Dema Dema commented Dec 6, 2019

Is there anything else I should do to this PR?..

@peterhoeg peterhoeg merged commit 6ac6bf2 into NixOS:master Jan 13, 2020
15 checks passed
15 checks passed
neovim-qt on aarch64-linux Failure
Details
neovim-qt on x86_64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@peterhoeg
Copy link
Member

@peterhoeg peterhoeg commented Jan 13, 2020

Thank you for the PR and your patience @Dema!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.