Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab: 12.4.2 -> 12.4.3 #73857

Merged
merged 1 commit into from Nov 25, 2019
Merged

gitlab: 12.4.2 -> 12.4.3 #73857

merged 1 commit into from Nov 25, 2019

Conversation

@petabyteboy
Copy link
Member

petabyteboy commented Nov 21, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @talyz @fpletz @globin @krav

@petabyteboy petabyteboy force-pushed the petabyteboy:feature/gitlab-12-4-3 branch from 93d8645 to f53fe02 Nov 21, 2019
@talyz
talyz approved these changes Nov 21, 2019
Copy link
Contributor

talyz left a comment

Looks good!

  • Built with nix-review pr 73857
  • Tested a few things manually in local VM
@talyz
Copy link
Contributor

talyz commented Nov 22, 2019

cc @flokli

@flokli flokli merged commit e073489 into NixOS:master Nov 25, 2019
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
gitlab on aarch64-linux Success
Details
gitlab on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@flokli
Copy link
Contributor

flokli commented Nov 25, 2019

backported to 19.09 in 105e528.

@flokli
Copy link
Contributor

flokli commented Nov 25, 2019

Hm, it seems 12.5 was also released on Nov 22: https://about.gitlab.com/blog/2019/11/22/gitlab-12-5-released/

Anybody already on it? 😆

@talyz
Copy link
Contributor

talyz commented Nov 26, 2019

Oh, I'll get on it today :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.