Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: enable some of broken tests #73861

Merged
merged 1 commit into from Dec 6, 2019
Merged

Conversation

@xfix
Copy link
Contributor

@xfix xfix commented Nov 21, 2019

Motivation for this change

Enabled tests because they could be enabled. I think we may want to do some sort of change in git anyway because of #73806, so rebuild is non-issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @peti @the-kenny @wmertens @globin

@FRidh
Copy link
Member

@FRidh FRidh commented Nov 24, 2019

needs rebase

@FRidh FRidh added this to WIP in Staging Nov 24, 2019
@xfix
Copy link
Contributor Author

@xfix xfix commented Nov 24, 2019

Done.

@FRidh
Copy link
Member

@FRidh FRidh commented Nov 24, 2019

rebase, don't merge.

@xfix xfix force-pushed the xfix:git-enable-some-of-broken-tests branch from 9d7dc9d to c7a121f Nov 24, 2019
@xfix
Copy link
Contributor Author

@xfix xfix commented Nov 24, 2019

Rebased.

@ofborg ofborg bot requested a review from wmertens Nov 24, 2019
@xfix
Copy link
Contributor Author

@xfix xfix commented Nov 24, 2019

Hm, weird, build fails, but only on x86_64-linux. I guess there may be something non-deterministic then?

Although checking the result, the test that fails is t5319-multi-pack-index, so... I don't know, I did nothing about that one.

@xfix xfix force-pushed the xfix:git-enable-some-of-broken-tests branch from c7a121f to 6e6b6a7 Nov 29, 2019
@xfix
Copy link
Contributor Author

@xfix xfix commented Nov 29, 2019

Rebased again due to another merge conflict.

@Mic92
Copy link
Contributor

@Mic92 Mic92 commented Nov 29, 2019

@GrahamcOfBorg build git

@peti peti merged commit fa9159b into NixOS:staging Dec 6, 2019
16 checks passed
16 checks passed
git on x86_64-darwin Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
git on aarch64-linux Success
Details
git on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Staging automation moved this from WIP to Done Dec 6, 2019
@bdesham bdesham mentioned this pull request Feb 9, 2020
2 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.