Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.tensorflow-tensorboard: add wheel as runtime dep #73870

Closed

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 21, 2019

The cli requires the wheel package to determine
entry points for execution.

(cherry picked from commit 7d091ce)
Signed-off-by: Jonathan Ringer jonringer117@gmail.com

Motivation for this change

backport of #73842

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

The cli requires the wheel package to determine
entry points for execution.

(cherry picked from commit 7d091ce)
Signed-off-by: Jonathan Ringer <jonringer117@gmail.com>
@jonringer jonringer requested a review from FRidh as a code owner Nov 21, 2019
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Nov 21, 2019

@GrahamcOfBorg build python3Packages.tensorflow-tensorboard pythonPackages.tensorflow-tensorboard

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Nov 21, 2019

looks like i need to backport the bump as well for my changes to not be broken

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Jan 9, 2020

no desire to figure out changeset needed for proper backport

@jonringer jonringer closed this Jan 9, 2020
@jonringer jonringer deleted the jonringer:fix-tensorboard-stable branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.