Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aerc: 0.2.1 -> 0.3.0 #73873

Merged
merged 1 commit into from Nov 25, 2019
Merged

aerc: 0.2.1 -> 0.3.0 #73873

merged 1 commit into from Nov 25, 2019

Conversation

@xwvvvvwx
Copy link
Contributor

xwvvvvwx commented Nov 21, 2019

Motivation for this change

version bump

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @tadeokondrak

@tilpner
Copy link
Member

tilpner commented Nov 21, 2019

This fails to start with

Failed to load config: Can't find template - quoted_reply

The previous version starts into a TUI just fine

@xwvvvvwx
Copy link
Contributor Author

xwvvvvwx commented Nov 21, 2019

oh! I'm not using the default config locally so I missed this. Thanks so much for the heads up 🙏 Fixing now.

Copy link
Contributor

jonringer left a comment

nix-review passes on NixOS
diff LGTM
commits LGTM
executable seems to work

[4 built, 7 copied (391.7 MiB), 99.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73873
1 package were built:
aerc
@jonringer
Copy link
Contributor

jonringer commented Nov 22, 2019

oh, assumed there was a aerc --config-path=../. type option, didn't realize this was a regression :)

@lovesegfault
Copy link
Contributor

lovesegfault commented Nov 25, 2019

@xwvvvvwx Did you push the fix? is this ready for merging?

- bump version
- build with notmuch support
- substitute @SHAREDIR@ in aerc.conf for the `template-dirs` key
- place ncurses instead of ncurses.dev in PATH (cannot find infocmp otherwise)
@xwvvvvwx xwvvvvwx force-pushed the xwvvvvwx:aerc-0.3.0 branch from bf17472 to 95fd0cd Nov 25, 2019
@xwvvvvwx
Copy link
Contributor Author

xwvvvvwx commented Nov 25, 2019

Apologies for the delay. I believe this is now ready to merge.

Rebased on master and made the following changes:

  • build with notmuch support
  • substitute @SHAREDIR@ in aerc.conf for the template-dirs key
  • place ncurses instead of ncurses.dev in PATH (aerc would otherwise panic at runtime as it could not find infocmp)
Copy link
Contributor

jonringer left a comment

nix-review passes on NixOS
diff LGTM
commits LGTM

https://github.com/NixOS/nixpkgs/pull/73873
1 package were built:
aerc
@jonringer
Copy link
Contributor

jonringer commented Nov 25, 2019

@GrahamcOfBorg build aerc

@jonringer jonringer merged commit cb8aa20 into NixOS:master Nov 25, 2019
15 of 16 checks passed
15 of 16 checks passed
aerc on x86_64-linux
Details
Evaluation Performance Report Evaluator Performance Report
Details
aerc on aarch64-linux Success
Details
aerc on x86_64-darwin Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
mkf added a commit to mkf/etc-nixos that referenced this pull request Nov 26, 2019
mkf added a commit to mkf/etc-nixos that referenced this pull request Nov 26, 2019
mkf added a commit to mkf/etc-nixos that referenced this pull request Nov 26, 2019
@xwvvvvwx xwvvvvwx deleted the xwvvvvwx:aerc-0.3.0 branch Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.