Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pydocstyle: 2.1.1 -> 4.0.1 #73889

Merged
merged 2 commits into from Nov 22, 2019
Merged

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 21, 2019

Motivation for this change

noticed it was horribly out of date

froze 2.1.1 for python2, bumped python3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

python3.8 failures are due to python38Packages.rope being broken upstream.

[12 built (2 failed), 234 copied (399.1 MiB), 76.3 MiB DL]
error: build of '/nix/store/bbp1jd411v4yyszmk3ydk2k5bqj3v678-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/73889
4 package failed to build:
python38Packages.pyls-black python38Packages.pyls-isort python38Packages.pyls-mypy python38Packages.python-language-server

13 package were built:
esphome esptool python37Packages.flake8-import-order python37Packages.pydocstyle python37Packages.pylama python37Packages.pyls-black python37Packages.pyls-isort python37Packages.pyls-mypy python37Packages.python-language-server python38Packages.flake8-import-order python38Packages.pydocstyle python38Packages.pylama todoman
@jonringer jonringer requested a review from FRidh as a code owner Nov 21, 2019
@jonringer jonringer changed the title Bump pydocstyle python3Packages.pydocstyle: 2.1.1 -> 4.0.1 Nov 21, 2019
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Nov 22, 2019

created issue for rope to support python3.8 here: python-rope/rope#277

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Nov 22, 2019

@GrahamcOfBorg build esphome esptool python37Packages.flake8-import-order python37Packages.pydocstyle python37Packages.pylama python37Packages.pyls-black python37Packages.pyls-isort python37Packages.pyls-mypy python37Packages.python-language-server python38Packages.flake8-import-order python38Packages.pydocstyle python38Packages.pylama todoman

@jonringer jonringer merged commit 148e772 into NixOS:master Nov 22, 2019
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
esphome, esptool, python37Packages.flake8-import-order, python37Packages.pydocstyle, python37Packages.pylama, python37Packages.pyls-black, python37Packages.pyls-isort, python37Packages.pyls-mypy, python37Packages.python-language-server, python38Packages.flake8-import-order, python38Packages.pydocstyle, python38Packages.pylama, todoman on aarch64-linux Success
Details
esphome, esptool, python37Packages.flake8-import-order, python37Packages.pydocstyle, python37Packages.pylama, python37Packages.pyls-black, python37Packages.pyls-isort, python37Packages.pyls-mypy, python37Packages.python-language-server, python38Packages.flake8-import-order, python38Packages.pydocstyle, python38Packages.pylama, todoman on x86_64-darwin Success
Details
esphome, esptool, python37Packages.flake8-import-order, python37Packages.pydocstyle, python37Packages.pylama, python37Packages.pyls-black, python37Packages.pyls-isort, python37Packages.pyls-mypy, python37Packages.python-language-server, python38Packages.flake8-import-order, python38Packages.pydocstyle, python38Packages.pylama, todoman on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jonringer jonringer deleted the jonringer:bump-pydocstyle branch Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.