Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.portalocker: 1.5.1 -> 1.5.2 #73893

Merged
merged 1 commit into from Nov 22, 2019

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 22, 2019

Motivation for this change

WoLpH/portalocker#47 was merged which fixes builds using dev versions of setuptools

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

azure-cli-core is broken on master

[8 built (3 failed), 175 copied (179.8 MiB), 27.1 MiB DL]
error: build of '/nix/store/bmfbmrmyyfa647hds0pxpfdcv2dvq2ha-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/73893
3 package failed to build:
python27Packages.azure-cli-core python37Packages.azure-cli-core python38Packages.azure-cli-core

9 package were built:
python27Packages.applicationinsights python27Packages.azure-cli-telemetry python27Packages.portalocker python37Packages.applicationinsights python37Packages.azure-cli-telemetry python37Packages.portalocker python38Packages.applicationinsights python38Packages.azure-cli-telemetry python38Packages.portalocker
@jonringer jonringer requested a review from FRidh as a code owner Nov 22, 2019
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Nov 22, 2019

seeing as build is currently broken, I will likely merge this once ofborg finishes

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Nov 22, 2019

@GrahamcOfBorg build python27Packages.applicationinsights python27Packages.azure-cli-telemetry python27Packages.portalocker python37Packages.applicationinsights python37Packages.azure-cli-telemetry python37Packages.portalocker python38Packages.applicationinsights python38Packages.azure-cli-telemetry python38Packages.portalocker

@jonringer jonringer merged commit 4ebb855 into NixOS:master Nov 22, 2019
15 of 16 checks passed
15 of 16 checks passed
python27Packages.applicationinsights, python27Packages.azure-cli-telemetry, python27Packages.portalocker, python37Packages.applicationinsights, python37Packages.azure-cli-telemetry, python37Packages.portalocker, python38Packages.applicationinsights, python38Packages.azure-cli-telemetry, python38Packages.portalocker on x86_64-darwin
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python27Packages.applicationinsights, python27Packages.azure-cli-telemetry, python27Packages.portalocker, python37Packages.applicationinsights, python37Packages.azure-cli-telemetry, python37Packages.portalocker, python38Packages.applicationinsights, python38Packages.azure-cli-telemetry, python38Packages.portalocker on aarch64-linux Success
Details
python27Packages.applicationinsights, python27Packages.azure-cli-telemetry, python27Packages.portalocker, python37Packages.applicationinsights, python37Packages.azure-cli-telemetry, python37Packages.portalocker, python38Packages.applicationinsights, python38Packages.azure-cli-telemetry, python38Packages.portalocker on x86_64-linux Success
Details
@jonringer jonringer deleted the jonringer:bump-portalocker branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.