Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kde-frameworks.extra-cmake-modules: allow for unset qtPluginPrefix #73903

Merged
merged 1 commit into from Nov 23, 2019

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 22, 2019

Motivation for this change

pretty sure this is not meant to always be set, fixes fcitx build

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer jonringer force-pushed the jonringer:fix-qtplugin-options branch from 9567f0f to 3dfaf56 Nov 22, 2019
@matthewbauer matthewbauer requested a review from Ericson2314 Nov 22, 2019
@Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Nov 23, 2019

Thanks!

@Ericson2314 Ericson2314 merged commit 46acc24 into NixOS:master Nov 23, 2019
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jonringer jonringer deleted the jonringer:fix-qtplugin-options branch Nov 23, 2019
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Nov 23, 2019

I probably should have made this against staging... oh well, :)

@Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Nov 23, 2019

Less than 1000, so eh. It was fixing a regression too.

@ttuegel
Copy link
Member

@ttuegel ttuegel commented Dec 1, 2019

pretty sure this is not meant to always be set

@jonringer qtPluginPrefix must always be set for a Qt package. Is this a Qt package?

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Dec 2, 2019

@ttuegel this was specifically in regards to the fcitix package, I just saw that it was failing on hydra and this was the appropriate fix after set -u is now set globally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.